Finished task #97
Open
Finished task #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naXa777
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Score: 100 / 100.
I tested that your bootstrap, build & deploy scripts work. It's a good work!!
Found problems that don't affect your score:
- wrong target repository. you should create pull requests in your own fork of the repository.
-
bug: React routes don't work with AWS S3 + CloudFront
-
Other minor problems are highlighted in comments.
| "prettier": "prettier src --write", | ||
| "prepare": "cd aws-deployment && npm i", | ||
| "bootstrap": "npm run prepare && npm run build && cd aws-deployment && cdk bootstrap", | ||
| "deploy": "npm run bootstrap && cd aws-deployment && cdk deploy " |
There was a problem hiding this comment.
Suggested change
| "deploy": "npm run bootstrap && cd aws-deployment && cdk deploy " | |
| "deploy": "cd aws-deployment && cdk deploy " |
cdk bootstrap should only be run once. While npm run deploy command is used every time when re-deploy is needed. so it's not correct to include npm run bootstrap call in the deploy command.
Comment on lines
+1
to
+8
| import * as route53 from 'aws-cdk-lib/aws-route53'; | ||
| import * as s3 from 'aws-cdk-lib/aws-s3'; | ||
| import * as acm from 'aws-cdk-lib/aws-certificatemanager'; | ||
| import * as cloudfront from 'aws-cdk-lib/aws-cloudfront'; | ||
| import * as s3deploy from 'aws-cdk-lib/aws-s3-deployment'; | ||
| import * as targets from 'aws-cdk-lib/aws-route53-targets'; | ||
| import * as cloudfront_origins from 'aws-cdk-lib/aws-cloudfront-origins'; | ||
| import {CfnOutput, Duration, RemovalPolicy, Stack, StackProps} from 'aws-cdk-lib'; |
There was a problem hiding this comment.
delete unused imports
Suggested change
| import * as route53 from 'aws-cdk-lib/aws-route53'; | |
| import * as s3 from 'aws-cdk-lib/aws-s3'; | |
| import * as acm from 'aws-cdk-lib/aws-certificatemanager'; | |
| import * as cloudfront from 'aws-cdk-lib/aws-cloudfront'; | |
| import * as s3deploy from 'aws-cdk-lib/aws-s3-deployment'; | |
| import * as targets from 'aws-cdk-lib/aws-route53-targets'; | |
| import * as cloudfront_origins from 'aws-cdk-lib/aws-cloudfront-origins'; | |
| import {CfnOutput, Duration, RemovalPolicy, Stack, StackProps} from 'aws-cdk-lib'; | |
| import * as s3 from 'aws-cdk-lib/aws-s3'; | |
| import * as cloudfront from 'aws-cdk-lib/aws-cloudfront'; | |
| import * as s3deploy from 'aws-cdk-lib/aws-s3-deployment'; | |
| import * as cloudfront_origins from 'aws-cdk-lib/aws-cloudfront-origins'; | |
| import {Duration, RemovalPolicy, Stack, StackProps} from 'aws-cdk-lib'; |
| { | ||
| httpStatus: 403, | ||
| responseHttpStatus: 403, | ||
| responsePagePath: '/error.html', |
There was a problem hiding this comment.
where's error.html file? It looks like you are referencing a non-existent file here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK-2.1 Manual Deployment
S3 URL(Blocked) - https://task-1-rs.s3.eu-central-1.amazonaws.com/index.html
CloudFront URL - https://dbk4hrf7n35us.cloudfront.net/
TASK-2.2 Automated Deployment
S3 URL(Blocked) - https://my-rs-bucket-ttt.s3.eu-central-1.amazonaws.com/index.html
CloudFront URL - https://d2rv8rvax2fpqy.cloudfront.net/
npm run deploy - for deploying