Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code #62

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+324 −272
Open

Clean code #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
09d0441
add Html5 DOCTYPE tag according to rule 2.2 in html-and-css.md
datots Feb 19, 2024
f86a83a
update CSS according to BEM to rule 2.1 in html-and-css-extended.md
datots Feb 19, 2024
4b433d3
refactor: app.js according to BEM rule
datots Feb 19, 2024
b703df9
updated
datots Feb 20, 2024
63d91f3
Update index.html
datots Feb 20, 2024
9579257
Update index.html
datots Feb 21, 2024
c903e0f
Update index.html
datots Feb 21, 2024
296faaa
Update style.css
datots Feb 21, 2024
466c582
Update app.js
datots Feb 21, 2024
56c3475
Update index.html
datots Feb 21, 2024
e1b306e
Update index.html
datots Feb 21, 2024
4987e30
Update index.html
datots Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
280 changes: 127 additions & 153 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,191 +5,165 @@
//Solution: Add interactivity so the user can manage daily tasks.
//Break things down into smaller steps and take each step at a time.


// Event handling, user interaction is what starts the code execution.

var taskInput=document.getElementById("new-task");//Add a new task.
var addButton=document.getElementsByTagName("button")[0];//first button
var incompleteTaskHolder=document.getElementById("incompleteTasks");//ul of #incompleteTasks
var completedTasksHolder=document.getElementById("completed-tasks");//completed-tasks

const taskInput = document.querySelector(".new-task"); //Add a new task.
const addButton = document.querySelector(".add-item__button"); //first button
const incompleteTaskHolder = document.querySelector(".incomplete-tasks"); //ul of #incompleteTasks
const completedTasksHolder = document.querySelector(".completed-tasks"); //completed-tasks

//New task list item
var createNewTaskElement=function(taskString){

var listItem=document.createElement("li");

//input (checkbox)
var checkBox=document.createElement("input");//checkbx
//label
var label=document.createElement("label");//label
//input (text)
var editInput=document.createElement("input");//text
//button.edit
var editButton=document.createElement("button");//edit button

//button.delete
var deleteButton=document.createElement("button");//delete button
var deleteButtonImg=document.createElement("img");//delete button image

label.innerText=taskString;
label.className='task';

//Each elements, needs appending
checkBox.type="checkbox";
editInput.type="text";
editInput.className="task";

editButton.innerText="Edit"; //innerText encodes special characters, HTML does not.
editButton.className="edit";

deleteButton.className="delete";
deleteButtonImg.src='./remove.svg';
deleteButton.appendChild(deleteButtonImg);


//and appending.
listItem.appendChild(checkBox);
listItem.appendChild(label);
listItem.appendChild(editInput);
listItem.appendChild(editButton);
listItem.appendChild(deleteButton);
return listItem;
}



var addTask=function(){
console.log("Add Task...");
//Create a new list item with the text from the #new-task:
if (!taskInput.value) return;
var listItem=createNewTaskElement(taskInput.value);
const createNewTaskElement = function (taskString) {
const listItem = document.createElement("li");

//input (checkbox)
const checkBox = document.createElement("input"); //checkbx
//label
const label = document.createElement("label"); //label
//input (text)
const editInput = document.createElement("input"); //text
//button.edit
const editButton = document.createElement("button"); //edit button

//button.delete
const deleteButton = document.createElement("button"); //delete button
const deleteButtonImg = document.createElement("img"); //delete button image

label.innerText = taskString;
label.className = "task";

//Each elements, needs appending
checkBox.type = "checkbox";
editInput.type = "text";
editInput.className = "task";

editButton.innerText = "Edit"; //innerText encodes special characters, HTML does not.
editButton.className = "edit";

deleteButton.className = "delete";
deleteButtonImg.src = "./remove.svg";
deleteButton.appendChild(deleteButtonImg);

//and appending.
listItem.appendChild(checkBox);
listItem.appendChild(label);
listItem.appendChild(editInput);
listItem.appendChild(editButton);
listItem.appendChild(deleteButton);
return listItem;
};

//Append listItem to incompleteTaskHolder
incompleteTaskHolder.appendChild(listItem);
bindTaskEvents(listItem, taskCompleted);
const addTask = () => {
console.log("Add Task...");
//Create a new list item with the text from the #new-task:
if (!taskInput.value) return;
const listItem = createNewTaskElement(taskInput.value);

taskInput.value="";
//Append listItem to incompleteTaskHolder
incompleteTaskHolder.appendChild(listItem);
bindTaskEvents(listItem, taskCompleted);

}
taskInput.value = "";
};

//Edit an existing task.

var editTask=function(){
console.log("Edit Task...");
console.log("Change 'edit' to 'save'");


var listItem=this.parentNode;

var editInput=listItem.querySelector('input[type=text]');
var label=listItem.querySelector("label");
var editBtn=listItem.querySelector(".edit");
var containsClass=listItem.classList.contains("editMode");
//If class of the parent is .editmode
if(containsClass){

//switch to .editmode
//label becomes the inputs value.
label.innerText=editInput.value;
editBtn.innerText="Edit";
}else{
editInput.value=label.innerText;
editBtn.innerText="Save";
}

//toggle .editmode on the parent.
listItem.classList.toggle("editMode");
const editTask = function () {
console.log("Edit Task...");
console.log("Change 'edit' to 'save'");

const listItem = this.parentNode;

const editInput = listItem.querySelector("input[type=text]");
const label = listItem.querySelector("label");
const editBtn = listItem.querySelector(".edit");
const containsClass = listItem.classList.contains("edit-list");
//If class of the parent is .editmode
if (containsClass) {
//switch to .editmode
//label becomes the inputs value.
label.innerText = editInput.value;
editBtn.innerText = "Edit";
} else {
editInput.value = label.innerText;
editBtn.innerText = "Save";
}

//toggle .editmode on the parent.
listItem.classList.toggle("edit-list");
};


//Delete task.
var deleteTask=function(){
console.log("Delete Task...");

var listItem=this.parentNode;
var ul=listItem.parentNode;
//Remove the parent list item from the ul.
ul.removeChild(listItem);

}
const deleteTask = function () {
console.log("Delete Task...");

const listItem = this.parentNode;
const ul = listItem.parentNode;
//Remove the parent list item from the ul.
ul.removeChild(listItem);
};

//Mark task completed
var taskCompleted=function(){
console.log("Complete Task...");

//Append the task list item to the #completed-tasks
var listItem=this.parentNode;
completedTasksHolder.appendChild(listItem);
bindTaskEvents(listItem, taskIncomplete);

}


var taskIncomplete=function(){
console.log("Incomplete Task...");
//Mark task as incomplete.
//When the checkbox is unchecked
//Append the task list item to the #incompleteTasks.
var listItem=this.parentNode;
incompleteTaskHolder.appendChild(listItem);
bindTaskEvents(listItem,taskCompleted);
}
const taskCompleted = function () {
console.log("Complete Task...");

//Append the task list item to the #completed-tasks
const listItem = this.parentNode;
completedTasksHolder.appendChild(listItem);
bindTaskEvents(listItem, taskIncomplete);
};

const taskIncomplete = function () {
console.log("Incomplete Task...");
//Mark task as incomplete.
//When the checkbox is unchecked
//Append the task list item to the #incompleteTasks.
const listItem = this.parentNode;
incompleteTaskHolder.appendChild(listItem);
bindTaskEvents(listItem, taskCompleted);
};

var ajaxRequest=function(){
console.log("AJAX Request");
}
const ajaxRequest = function () {
console.log("AJAX Request");
};

//The glue to hold it all together.


//Set the click handler to the addTask function.
addButton.onclick=addTask;
addButton.addEventListener("click",addTask);
addButton.addEventListener("click",ajaxRequest);


var bindTaskEvents=function(taskListItem,checkBoxEventHandler){
console.log("bind list item events");
//select ListItems children
var checkBox=taskListItem.querySelector("input[type=checkbox]");
var editButton=taskListItem.querySelector("button.edit");
var deleteButton=taskListItem.querySelector("button.delete");


//Bind editTask to edit button.
editButton.onclick=editTask;
//Bind deleteTask to delete button.
deleteButton.onclick=deleteTask;
//Bind taskCompleted to checkBoxEventHandler.
checkBox.onchange=checkBoxEventHandler;
}
addButton.addEventListener("click", addTask);
addButton.addEventListener("click", addTask);
addButton.addEventListener("click", ajaxRequest);

const bindTaskEvents = function (taskListItem, checkBoxEventHandler) {
console.log("bind list item events");
//select ListItems children
const checkBox = taskListItem.querySelector("input[type=checkbox]");
const editButton = taskListItem.querySelector("button.edit");
const deleteButton = taskListItem.querySelector("button.delete");

//Bind editTask to edit button.
editButton.addEventListener("click", editTask);
//Bind deleteTask to delete button.
deleteButton.addEventListener("click", deleteTask);
//Bind taskCompleted to checkBoxEventHandler.
checkBox.addEventListener("change", checkBoxEventHandler);
};

//cycle over incompleteTaskHolder ul list items
//for each list item
for (var i=0; i<incompleteTaskHolder.children.length;i++){

//bind events to list items chldren(tasksCompleted)
bindTaskEvents(incompleteTaskHolder.children[i],taskCompleted);
for (let element of incompleteTaskHolder.children) {
//bind events to list items chldren(tasksCompleted)
bindTaskEvents(element, taskCompleted);
}




//cycle over completedTasksHolder ul list items
for (var i=0; i<completedTasksHolder.children.length;i++){
//bind events to list items chldren(tasksIncompleted)
bindTaskEvents(completedTasksHolder.children[i],taskIncomplete);
for (let element of completedTasksHolder.children) {
//bind events to list items chldren(tasksIncompleted)
bindTaskEvents(element, taskIncomplete);
}




// Issues with usability don't get seen until they are in front of a human tester.

//prevent creation of empty tasks.

//Change edit to save when you are in edit mode.
//Change edit to save when you are in edit mode.
Loading