Clean code s1e1 #38
Open
Clean code s1e1 #38
+168
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiKseniaQA
commented
Jan 8, 2024
MiKseniaQA
commented
- Task: https://github.com/rolling-scopes-school/tasks/blob/master/stage1/modules/clean-code/clean-code-s1e1.md#application-functionality
- Screenshot:
- Deploy: https://courageous-medovik-991a42.netlify.app/
- Done 08.01.2024 / deadline 09.01.2024
- Score: 38/45
- Basic rule 1.1. Indentation (2/2)
- Basic rule 1.2. Use lowercase (2/2)
- Basic rule 1.3. Quotes in HTML & CSS files (2/2)
- Basic rule 2.1. HTML. Formatting (2/2)
- Basic rule 2.2. Document Type. (2/2)
- Basic rule 2.3. Named character references (2/2)
- Basic rule 2.4. 'type' attribute (2/2)
- Basic rule 3.1. Single style for selectors naming (2/2)
- Basic rule 3.2. Meaningful naming of identifiers and classes (2/2)
- Basic rule 3.3. Keep the names of identifiers and classes concise (2/2)
- Basic rule 3.4. Tag selectors (2/2)
- Basic rule 3.5. Indentation in blocks (0/2)
- Basic rule 3.6. Space after property name (2/2)
- Basic rule 3.7. Semicolon after properties (2/2)
- Basic rule 3.8. Separate selectors and properties (2/2)
- Extended rule 1.1. HTML. Semantics (5/5)
- Extended rule 1.2. Media alternatives (5/5)
- Extended rule 2.1. BEM (0/5)
- Вёрстка, дизайн, UI (15/30)
…ributes in index.html and properties in style.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.