From d38faf6ae7be2bd7cecd6b3aa45fd37895611cfe Mon Sep 17 00:00:00 2001 From: Andrey Kornich Date: Tue, 29 Mar 2022 13:40:07 -0700 Subject: [PATCH 1/6] fix: ref #626 - fixed telemetry collector initialization - added test coverage of the telemetry collector initialization --- Rollbar/Config/_Config.cd | 126 ++++++++++++++++++ .../Telemetry/RollbarTelemetryCollector.cs | 19 ++- Rollbar/_Rollbar.cd | 4 +- Rollbar/_RollbarConfig.cd | 25 ++-- 4 files changed, 157 insertions(+), 17 deletions(-) create mode 100644 Rollbar/Config/_Config.cd diff --git a/Rollbar/Config/_Config.cd b/Rollbar/Config/_Config.cd new file mode 100644 index 00000000..5754aa82 --- /dev/null +++ b/Rollbar/Config/_Config.cd @@ -0,0 +1,126 @@ + + + + + + AAAAACAAAAAAAAAAAAAAgAACAAIAAAACAAAAEAAAAAA= + Config\HttpProxyOptions.cs + + + + + + + AAAAACBACAIAAQAAAAAAgAAAAgAAAAAAIAAAAAAAAAA= + Config\RollbarDataSecurityOptions.cs + + + + + + + + + + + + Config\RollbarDestinationOptions.cs + + + + + AAAAACACAAAASAAAAAAAgAAAEAAgAAAAAAAAAAAAAIA= + Config\RollbarDestinationOptions.cs + + + + + + + AAAAACgAIAAAAICABAAAwAAEAAAAAAIIBAAEBAQAAAA= + Config\RollbarDeveloperOptions.cs + + + + + + + + + Config\RollbarInfrastructureConfig.cs + + + + + AEAAASAABAAABAAAEgAAgAAiAAAAAAAIAAAAAAAAAAA= + Config\RollbarInfrastructureConfig.cs + + + + + + + AAgACCAAACAAAAAAAABA2AAAAABAAAAIAAAAAAAAAAQ= + Config\RollbarInfrastructureOptions.cs + + + + + + + + + Config\RollbarLoggerConfig.cs + + + + + CAAAAWgQQAIBAQAACAwAwAAAIAAAAAAgDAAgAAAIABg= + Config\RollbarLoggerConfig.cs + + + + + + + ABACACAAAAAAAICAAAAAgAAAAAAAAAAQAACAAACAEAA= + Config\RollbarOfflineStoreOptions.cs + + + + + + + + + + + + Config\RollbarPayloadAdditionOptions.cs + + + + + AIAACDAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAgAEAAA= + Config\RollbarPayloadAdditionOptions.cs + + + + + + + AAACACAAAAAAAAAAAAAAgAUCAAAAAAAQAAAAAAAAAAA= + Config\RollbarPayloadManipulationOptions.cs + + + + + + + AAAIACAAAAAAAFAAAAAigAAAAAAAAAAAAAACABAAAAI= + Config\RollbarTelemetryOptions.cs + + + + + \ No newline at end of file diff --git a/Rollbar/Telemetry/RollbarTelemetryCollector.cs b/Rollbar/Telemetry/RollbarTelemetryCollector.cs index 4331b879..a8ea030f 100644 --- a/Rollbar/Telemetry/RollbarTelemetryCollector.cs +++ b/Rollbar/Telemetry/RollbarTelemetryCollector.cs @@ -4,7 +4,6 @@ using System.Diagnostics; using System.Threading; - using Rollbar; using Rollbar.DTOs; /// @@ -37,6 +36,8 @@ public static RollbarTelemetryCollector? Instance internal RollbarTelemetryCollector() { traceSource.TraceInformation($"Creating the {typeof(RollbarTelemetryCollector).Name}..."); + + this._telemetryQueue.QueueDepth = 0; // since we do not have valid telemetry config assigned yet... } #endregion singleton implementation @@ -51,12 +52,21 @@ internal void Init(IRollbarTelemetryOptions options) } this._config = options; - - if(this._config != null) + + + + if (this._config != null) { + // let's resync with relevant config settings: + this._telemetryQueue.QueueDepth = this._config.TelemetryQueueDepth; + this._config.Reconfigured += _config_Reconfigured; this.StartAutocollection(); } + else + { + this._telemetryQueue.QueueDepth = 0; + } } /// @@ -142,9 +152,6 @@ public IRollbarTelemetryCollector StartAutocollection() return this; // this, essentially, means the auto-collection is off... } - // let's resync with relevant config settings: - this._telemetryQueue.QueueDepth = this.Config.TelemetryQueueDepth; - lock (_syncRoot) { if (this._telemetryThread == null) diff --git a/Rollbar/_Rollbar.cd b/Rollbar/_Rollbar.cd index 9ff7b4c4..ad11d54d 100644 --- a/Rollbar/_Rollbar.cd +++ b/Rollbar/_Rollbar.cd @@ -54,7 +54,7 @@ - + Infrastructure\RollbarQueueController.cs @@ -86,7 +86,7 @@ - + AAAAAAAAAgIAAAAAQABAAAAAAAAAAAAAAAAAAAAAAAA= IRollbar.cs diff --git a/Rollbar/_RollbarConfig.cd b/Rollbar/_RollbarConfig.cd index 4554aaa6..abe7f09e 100644 --- a/Rollbar/_RollbarConfig.cd +++ b/Rollbar/_RollbarConfig.cd @@ -1,35 +1,35 @@  - + AAAAAAAAAAAAAAAAAAAAAAACAAIAAAACAAAAAAAAAAA= IHttpProxyOptions.cs - + AAAAAABACAAAAQAAAAAAAAAAAgAAAAAAIAAAAAAAAAA= IRollbarDataSecurityOptions.cs - + AAAAAAACAAAAQAAAAAAAAAAAEAAAAAAAAAAAAAAAAAA= IRollbarDestinationOptions.cs - + AAAAAAAAAAAAAIAAAAAAAAAAAAAAAAIIAAAEBAQAAAA= IRollbarDeveloperOptions.cs - + AAAACAAAAAAAAAAAAAAAEAAAAABAAAAIAAAAAAAAAAA= IRollbarInfrastructureOptions.cs @@ -43,14 +43,14 @@ - + AIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAgAAAAA= IRollbarPayloadAdditionOptions.cs - + AAACAAAAAAAAAAAAAAAAAAUAAAAAAAAAAAAAAAAAAAA= IRollbarPayloadManipulationOptions.cs @@ -64,14 +64,14 @@ - + AAAAAAAABAAABAAAAAAAAAAgAAAAAAAIAAAAAAAAAAA= IRollbarInfrastructureConfig.cs - + AAAAAAAAAAAAAICAAAAAAAAAAAAAAAAAAAAAAACAAAA= IRollbarOfflineStoreOptions.cs @@ -91,6 +91,13 @@ Common\IReconfigurable.cs + + + + AAAAAAAAAAAAABAAAAACAAAAAAAAAAAAAAACABAAAAA= + IRollbarTelemetryOptions.cs + + From e7c71920771c087f2b4675248546eed79066aa40 Mon Sep 17 00:00:00 2001 From: Andrey Kornich Date: Tue, 29 Mar 2022 13:40:42 -0700 Subject: [PATCH 2/6] fix: ref #626 --- .../RollbarInfrastructureConfigFixture.cs | 75 +++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/UnitTest.Rollbar/RollbarInfrastructureConfigFixture.cs b/UnitTest.Rollbar/RollbarInfrastructureConfigFixture.cs index 271e6f16..c914af31 100644 --- a/UnitTest.Rollbar/RollbarInfrastructureConfigFixture.cs +++ b/UnitTest.Rollbar/RollbarInfrastructureConfigFixture.cs @@ -3,6 +3,8 @@ namespace UnitTest.Rollbar { using global::Rollbar; + using global::Rollbar.DTOs; + using Microsoft.VisualStudio.TestTools.UnitTesting; using System; using System.Collections.Generic; @@ -15,6 +17,16 @@ public class RollbarInfrastructureConfigFixture [TestInitialize] public void SetupFixture() { + //var config = new RollbarInfrastructureConfig("access_token", "special_environment"); + + //if (RollbarInfrastructure.Instance.IsInitialized) + //{ + // RollbarInfrastructure.Instance.Config.Reconfigure(config); + //} + //else + //{ + // RollbarInfrastructure.Instance.Init(config); + //} } [TestCleanup] @@ -38,6 +50,69 @@ public void TestBasics() Console.WriteLine(); } + + [TestMethod] + public void CustomTelemetryOptionsReconfigured() + { + int expectedTelemetryQueueDepth = 20; + + var config = new RollbarInfrastructureConfig("access_token", "special_environment"); + + Assert.IsFalse(config.RollbarTelemetryOptions.TelemetryEnabled); + Assert.IsTrue(config.RollbarTelemetryOptions.TelemetryQueueDepth != expectedTelemetryQueueDepth); + Assert.IsTrue(config.RollbarTelemetryOptions.TelemetryAutoCollectionTypes == TelemetryType.None); + + var telemetryOptions = new RollbarTelemetryOptions(true, 20) + { + TelemetryAutoCollectionTypes = TelemetryType.Log | TelemetryType.Error | TelemetryType.Network + }; + config.RollbarTelemetryOptions.Reconfigure(telemetryOptions); + + Assert.IsTrue(config.RollbarTelemetryOptions.TelemetryEnabled); + Assert.AreEqual(expectedTelemetryQueueDepth, config.RollbarTelemetryOptions.TelemetryQueueDepth); + Assert.IsTrue((config.RollbarTelemetryOptions.TelemetryAutoCollectionTypes & TelemetryType.Log) == TelemetryType.Log); + Assert.IsTrue((config.RollbarTelemetryOptions.TelemetryAutoCollectionTypes & TelemetryType.Error) == TelemetryType.Error); + Assert.IsTrue((config.RollbarTelemetryOptions.TelemetryAutoCollectionTypes & TelemetryType.Network) == TelemetryType.Network); + Assert.IsTrue((config.RollbarTelemetryOptions.TelemetryAutoCollectionTypes & TelemetryType.Manual) == TelemetryType.None); + } + + [TestMethod] + public void CustomTelemetryOptionsMakeIntoTelemetryCollector() + { + int expectedTelemetryQueueDepth = 20; + + var config = new RollbarInfrastructureConfig("access_token", "special_environment"); + + Assert.IsFalse(config.RollbarTelemetryOptions.TelemetryEnabled); + Assert.IsTrue(config.RollbarTelemetryOptions.TelemetryQueueDepth != expectedTelemetryQueueDepth); + Assert.IsTrue(config.RollbarTelemetryOptions.TelemetryAutoCollectionTypes == TelemetryType.None); + + var telemetryOptions = new RollbarTelemetryOptions(true, 20) + { + TelemetryAutoCollectionTypes = TelemetryType.Log | TelemetryType.Error | TelemetryType.Network + }; + config.RollbarTelemetryOptions.Reconfigure(telemetryOptions); + + + if (RollbarInfrastructure.Instance.IsInitialized) + { + RollbarInfrastructure.Instance.Config.Reconfigure(config); + } + else + { + RollbarInfrastructure.Instance.Init(config); + } + + Assert.IsTrue(RollbarInfrastructure.Instance.TelemetryCollector.Config.TelemetryEnabled); + Assert.AreEqual(expectedTelemetryQueueDepth, RollbarInfrastructure.Instance.TelemetryCollector.Config.TelemetryQueueDepth); + Assert.IsTrue((RollbarInfrastructure.Instance.TelemetryCollector.Config.TelemetryAutoCollectionTypes & TelemetryType.Log) == TelemetryType.Log); + Assert.IsTrue((RollbarInfrastructure.Instance.TelemetryCollector.Config.TelemetryAutoCollectionTypes & TelemetryType.Error) == TelemetryType.Error); + Assert.IsTrue((RollbarInfrastructure.Instance.TelemetryCollector.Config.TelemetryAutoCollectionTypes & TelemetryType.Network) == TelemetryType.Network); + Assert.IsTrue((RollbarInfrastructure.Instance.TelemetryCollector.Config.TelemetryAutoCollectionTypes & TelemetryType.Manual) == TelemetryType.None); + + Assert.AreEqual(expectedTelemetryQueueDepth, RollbarInfrastructure.Instance.TelemetryCollector.QueueDepth); + } + } } From 27f9396217d504bf1a26ff67aaab7367a0b3b809 Mon Sep 17 00:00:00 2001 From: Andrey Kornich Date: Tue, 29 Mar 2022 16:57:10 -0700 Subject: [PATCH 3/6] fix: resolve #626 fixed rollbar infrastructure initialization by the rollbar middleware and by the rollbar logger provider --- Rollbar.NetCore.AspNet/RollbarMiddleware.cs | 9 ++++++--- .../RollbarLoggerProvider.cs | 11 +++-------- Samples/Sample.AspNetCore2.WebApi/Startup.cs | 17 +++++++++++++++-- 3 files changed, 24 insertions(+), 13 deletions(-) diff --git a/Rollbar.NetCore.AspNet/RollbarMiddleware.cs b/Rollbar.NetCore.AspNet/RollbarMiddleware.cs index d41a3e5d..03e4d223 100644 --- a/Rollbar.NetCore.AspNet/RollbarMiddleware.cs +++ b/Rollbar.NetCore.AspNet/RollbarMiddleware.cs @@ -141,9 +141,12 @@ RequestDelegate nextRequestProcessor this._logger = loggerFactory.CreateLogger(); this._rollbarOptions = rollbarOptions.Value; - RollbarConfigurationUtil.DeduceRollbarTelemetryConfig(configuration); - RollbarInfrastructure.Instance?.TelemetryCollector?.StartAutocollection(); - RollbarConfigurationUtil.DeduceRollbarConfig(configuration); + if (!RollbarInfrastructure.Instance.IsInitialized) + { + RollbarConfigurationUtil.DeduceRollbarTelemetryConfig(configuration); + RollbarInfrastructure.Instance?.TelemetryCollector?.StartAutocollection(); + RollbarConfigurationUtil.DeduceRollbarConfig(configuration); + } } /// diff --git a/Rollbar.NetPlatformExtensions/RollbarLoggerProvider.cs b/Rollbar.NetPlatformExtensions/RollbarLoggerProvider.cs index 07255881..cf1b617b 100644 --- a/Rollbar.NetPlatformExtensions/RollbarLoggerProvider.cs +++ b/Rollbar.NetPlatformExtensions/RollbarLoggerProvider.cs @@ -69,17 +69,12 @@ public RollbarLoggerProvider( { if(configuration != null) { - this._rollbarInfrastructureConfig = RollbarConfigurationUtil.DeduceRollbarConfig(configuration); - if(RollbarInfrastructure.Instance.IsInitialized) - { - RollbarInfrastructure.Instance.Config.Reconfigure(this._rollbarInfrastructureConfig); - } - else + if (!RollbarInfrastructure.Instance.IsInitialized) { + this._rollbarInfrastructureConfig = RollbarConfigurationUtil.DeduceRollbarConfig(configuration); RollbarInfrastructure.Instance.Init(this._rollbarInfrastructureConfig); } - RollbarConfigurationUtil.DeduceRollbarTelemetryConfig(configuration); - _ = Rollbar.RollbarInfrastructure.Instance?.TelemetryCollector?.StartAutocollection(); + this._rollbarInfrastructureConfig = RollbarInfrastructure.Instance.Config; } if(options != null) diff --git a/Samples/Sample.AspNetCore2.WebApi/Startup.cs b/Samples/Sample.AspNetCore2.WebApi/Startup.cs index 063135e1..339713ed 100644 --- a/Samples/Sample.AspNetCore2.WebApi/Startup.cs +++ b/Samples/Sample.AspNetCore2.WebApi/Startup.cs @@ -12,6 +12,7 @@ using Microsoft.OpenApi.Models; using Rollbar; + using Rollbar.DTOs; using Rollbar.NetCore.AspNet; using Samples; @@ -40,7 +41,7 @@ public void ConfigureServices(IServiceCollection services) services.AddSingleton(); - ConfigureRollbarSingleton(); + ConfigureRollbarInfrastructure(); services.AddRollbarLogger(loggerOptions => { @@ -85,13 +86,14 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env) /// /// Configures the Rollbar singleton-like notifier. /// - private void ConfigureRollbarSingleton() + private void ConfigureRollbarInfrastructure() { RollbarInfrastructureConfig config = new RollbarInfrastructureConfig( RollbarSamplesSettings.AccessToken, RollbarSamplesSettings.Environment ); config.RollbarLoggerConfig.RollbarDeveloperOptions.LogLevel = ErrorLevel.Debug; + //RollbarDataSecurityOptions dataSecurityOptions = new RollbarDataSecurityOptions(); //dataSecurityOptions.ScrubFields = new string[] //{ @@ -100,8 +102,19 @@ private void ConfigureRollbarSingleton() //}; //config.RollbarLoggerConfig.RollbarDataSecurityOptions.Reconfigure(dataSecurityOptions); + var telemetryOptions = new RollbarTelemetryOptions(true, 20) + { + TelemetryAutoCollectionTypes = TelemetryType.Log | TelemetryType.Error | TelemetryType.Network + }; + config.RollbarTelemetryOptions.Reconfigure(telemetryOptions); + RollbarInfrastructure.Instance.Init(config); RollbarInfrastructure.Instance.QueueController.InternalEvent += OnRollbarInternalEvent; + + var telemetryBody = new LogTelemetry("Rollbar infrastructure initialized!"); + RollbarInfrastructure.Instance.TelemetryCollector.Capture(new Telemetry(TelemetrySource.Server, TelemetryLevel.Info, telemetryBody)); + + RollbarLocator.RollbarInstance.Info("Rollbar is ready to roll!"); } /// From 7e3251f62dd6b60c0e652fac44a76f3e605d6869 Mon Sep 17 00:00:00 2001 From: Andrey Kornich Date: Thu, 31 Mar 2022 12:22:00 -0700 Subject: [PATCH 4/6] feat: resolve #627 --- Rollbar/DTOs/Notifier.cs | 24 +++++++++++++++++++++ UnitTest.Rollbar/DTOs/DataFixture.cs | 2 +- UnitTest.Rollbar/DTOs/PayloadFixture.cs | 28 ++++++++++++++++++------- 3 files changed, 45 insertions(+), 9 deletions(-) diff --git a/Rollbar/DTOs/Notifier.cs b/Rollbar/DTOs/Notifier.cs index 61959429..92506b3a 100644 --- a/Rollbar/DTOs/Notifier.cs +++ b/Rollbar/DTOs/Notifier.cs @@ -28,6 +28,10 @@ public static class ReservedProperties /// The configuration /// public static readonly string Configuration = "configured_options"; + /// + /// The Rollbar Infrastructure configuration + /// + public static readonly string InfrastructureConfiguration = "infrastructure_options"; } /// @@ -85,6 +89,21 @@ public IRollbarLoggerConfig? Configuration get { return this[ReservedProperties.Configuration] as IRollbarLoggerConfig; } set { this[ReservedProperties.Configuration] = value; } } + /// + /// Gets or sets the Rollbar Infrastructure configuration. + /// + /// The configuration. + public IRollbarInfrastructureConfig? InfrastructureConfiguration + { + get + { + return this[ReservedProperties.InfrastructureConfiguration] as IRollbarInfrastructureConfig; + } + private set + { + this[ReservedProperties.InfrastructureConfiguration] = value; + } + } /// /// Initializes a new instance of the class. @@ -103,6 +122,11 @@ public Notifier(IDictionary? arbitraryKeyValuePairs) { this.Name = Notifier.notifierName; this.Version = Notifier.notifierAssemblyVersion; + + if (RollbarInfrastructure.Instance.IsInitialized) + { + this.InfrastructureConfiguration = RollbarInfrastructure.Instance.Config; + } } } } diff --git a/UnitTest.Rollbar/DTOs/DataFixture.cs b/UnitTest.Rollbar/DTOs/DataFixture.cs index 599478a6..c407ab8c 100644 --- a/UnitTest.Rollbar/DTOs/DataFixture.cs +++ b/UnitTest.Rollbar/DTOs/DataFixture.cs @@ -57,7 +57,7 @@ public void NotifierIsSet() var version = typeof(Data).Assembly.GetName().Version.ToString(3); string[] expected = string.Format("{{`name`:`Rollbar.NET`,`version`:`{0}`}}", version).TrimEnd('}').TrimEnd('`').Split(','); string[] actual = WhiteSpace.Replace(JsonConvert.SerializeObject(_basicData.Notifier), "").Replace('"', '`').Split(','); - Assert.AreEqual(2, actual.Length); + Assert.IsTrue(actual.Length >= 2); Assert.IsTrue(actual[0].StartsWith(expected[0].TrimEnd('`'))); // for name: Assert.IsTrue(actual[1].StartsWith(expected[1])); // for version: } diff --git a/UnitTest.Rollbar/DTOs/PayloadFixture.cs b/UnitTest.Rollbar/DTOs/PayloadFixture.cs index 707f8fce..be441293 100644 --- a/UnitTest.Rollbar/DTOs/PayloadFixture.cs +++ b/UnitTest.Rollbar/DTOs/PayloadFixture.cs @@ -84,14 +84,17 @@ public void BasicExceptionCreatesValidRollbarObject() Assert.AreEqual("c#", data["language"].Value()); var left = exceptionExample.Data.Notifier.ToArray(); - var right = data["notifier"].ToObject>(); + var right = data["notifier"].ToObject>(); Assert.AreEqual(left.Length, right.Count); int i = 0; while (i < right.Count) { Assert.IsTrue(right.ContainsKey(left[i].Key)); - Assert.AreEqual(right[left[i].Key], left[i].Value); + if (left[i].Value is String) + { + Assert.AreEqual(right[left[i].Key], left[i].Value); + } i++; } @@ -164,14 +167,17 @@ public void MessageCreatesValidRollbarObject() Assert.AreEqual("c#", data["language"].Value()); var left = messageException.Data.Notifier.ToArray(); - var right = data["notifier"].ToObject>(); + var right = data["notifier"].ToObject>(); Assert.AreEqual(left.Length, right.Count); int i = 0; while (i < right.Count) { Assert.IsTrue(right.ContainsKey(left[i].Key)); - Assert.AreEqual(right[left[i].Key], left[i].Value); + if (left[i].Value is String) + { + Assert.AreEqual(right[left[i].Key], left[i].Value); + } i++; } @@ -274,14 +280,17 @@ void traceFunc(JToken trace) //Assert.AreEqual(_exceptionExample.Data.Notifier.ToArray(), data["notifier"].ToObject>()); var left = aggregateExample.Data.Notifier.ToArray(); - var right = data["notifier"].ToObject>(); + var right = data["notifier"].ToObject>(); Assert.AreEqual(left.Length, right.Count); int i = 0; while (i < right.Count) { Assert.IsTrue(right.ContainsKey(left[i].Key)); - Assert.AreEqual(right[left[i].Key], left[i].Value); + if (left[i].Value is String) + { + Assert.AreEqual(right[left[i].Key], left[i].Value); + } i++; } @@ -354,14 +363,17 @@ public void CrashReportCreatesValidRollbarObject() Assert.AreEqual("c#", data["language"].Value()); var left = crashException.Data.Notifier.ToArray(); - var right = data["notifier"].ToObject>(); + var right = data["notifier"].ToObject>(); Assert.AreEqual(left.Length, right.Count); int i = 0; while (i < right.Count) { Assert.IsTrue(right.ContainsKey(left[i].Key)); - Assert.AreEqual(right[left[i].Key], left[i].Value); + if (left[i].Value is String) + { + Assert.AreEqual(right[left[i].Key], left[i].Value); + } i++; } From 786cd3aef3dfa6da19b9fdce96b8bc340c94f92c Mon Sep 17 00:00:00 2001 From: Andrey Kornich Date: Thu, 31 Mar 2022 12:26:40 -0700 Subject: [PATCH 5/6] chore: updated release notes for v5.1.3 release --- SdkCommon.csproj | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/SdkCommon.csproj b/SdkCommon.csproj index 6786317d..7ef05ef9 100644 --- a/SdkCommon.csproj +++ b/SdkCommon.csproj @@ -24,12 +24,13 @@ - 5.1.2 + 5.1.3 false - fix: resolve #623 - NullReference exception while initializing RollbarInfrastructure + fix: resolve #626 - Telemetry in DotNet Core 3.1 is not initialized + feat: resolve #627 - Capture RollbarInfrastructureConfig with each payload From 148a54b49856986e58978f8df6ba20f051b396d4 Mon Sep 17 00:00:00 2001 From: Andrey Kornich Date: Thu, 31 Mar 2022 12:39:45 -0700 Subject: [PATCH 6/6] chore: code cleanup --- Rollbar/Telemetry/RollbarTelemetryCollector.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/Rollbar/Telemetry/RollbarTelemetryCollector.cs b/Rollbar/Telemetry/RollbarTelemetryCollector.cs index a8ea030f..fa277191 100644 --- a/Rollbar/Telemetry/RollbarTelemetryCollector.cs +++ b/Rollbar/Telemetry/RollbarTelemetryCollector.cs @@ -53,8 +53,6 @@ internal void Init(IRollbarTelemetryOptions options) this._config = options; - - if (this._config != null) { // let's resync with relevant config settings: