diff --git a/Rollbar/Common/EmptyDisposable.cs b/Rollbar/Common/EmptyDisposable.cs index 4c581cc4..2685b63d 100644 --- a/Rollbar/Common/EmptyDisposable.cs +++ b/Rollbar/Common/EmptyDisposable.cs @@ -1,6 +1,7 @@ namespace Rollbar.Common { using System; + using System.Diagnostics; using System.Collections.Generic; using System.Text; @@ -11,46 +12,43 @@ public sealed class EmptyDisposable : IDisposable { - /// - /// Prevents a default instance of the class from being created. - /// - private EmptyDisposable() - { - } + private static readonly TraceSource traceSource = + new TraceSource(typeof(EmptyDisposable).FullName ?? "EmptyDisposable"); + + #region singleton implementation + + private static readonly Lazy lazySingleton = + new Lazy(() => new EmptyDisposable()); /// - /// Gets the singleton-like IRollbar instance. + /// Gets the instance. /// - /// - /// The single shared IRollbar instance. - /// + /// The instance. public static EmptyDisposable Instance { get { - return NestedSingleInstance.TheInstance; + return lazySingleton.Value; } } /// - /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources. + /// Prevents a default instance of the class from being created. /// - public void Dispose() + private EmptyDisposable() { - // no-op... + traceSource.TraceInformation($"Creating the {typeof(EmptyDisposable).Name}..."); } - private sealed class NestedSingleInstance - { - static NestedSingleInstance() - { - } + #endregion singleton implementation - private NestedSingleInstance() - { - } - internal static readonly EmptyDisposable TheInstance = new EmptyDisposable(); + /// + /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources. + /// + public void Dispose() + { + // no-op... } } } diff --git a/Rollbar/Infrastructure/RollbarConnectivityMonitor.cs b/Rollbar/Infrastructure/RollbarConnectivityMonitor.cs index da69da4b..e065efaf 100644 --- a/Rollbar/Infrastructure/RollbarConnectivityMonitor.cs +++ b/Rollbar/Infrastructure/RollbarConnectivityMonitor.cs @@ -10,7 +10,7 @@ /// Implements the /// /// - internal class RollbarConnectivityMonitor + internal sealed class RollbarConnectivityMonitor : IRollbarConnectivityMonitor , IDisposable { @@ -30,14 +30,14 @@ public static RollbarConnectivityMonitor? Instance { get { - return NestedSingleInstance.TheInstance; + return RollbarInfrastructure.Instance.ConnectivityMonitor as RollbarConnectivityMonitor; } } /// /// Prevents a default instance of the class from being created. /// - private RollbarConnectivityMonitor() + internal RollbarConnectivityMonitor() { TimeSpan initialDelay = TimeSpan.Zero; this._minMonitoringInterval = TimeSpan.FromSeconds(10); @@ -56,26 +56,6 @@ private RollbarConnectivityMonitor() this.CheckConnectivityStatus(null); } - /// - /// Class NestedSingleInstance. This class cannot be inherited. - /// - private sealed class NestedSingleInstance - { - /// - /// Prevents a default instance of the class from being created. - /// - private NestedSingleInstance() - { - } - - /// - /// The instance - /// - internal static readonly RollbarConnectivityMonitor? TheInstance = - RollbarInfrastructure.Instance.IsInitialized ? new RollbarConnectivityMonitor() - : null; - } - #endregion singleton implementation /// @@ -264,7 +244,7 @@ public static bool TestApiServer() /// /// true to release both managed and unmanaged resources; false to release only unmanaged resources. [System.Diagnostics.CodeAnalysis.SuppressMessage("Major Code Smell", "S1066:Collapsible \"if\" statements should be merged", Justification = "Promotes better code structure.")] - protected virtual void Dispose(bool disposing) + private void Dispose(bool disposing) { if(!_disposedValue) { diff --git a/Rollbar/Infrastructure/RollbarQueueController.cs b/Rollbar/Infrastructure/RollbarQueueController.cs index 35c59ba4..9191d65f 100644 --- a/Rollbar/Infrastructure/RollbarQueueController.cs +++ b/Rollbar/Infrastructure/RollbarQueueController.cs @@ -49,35 +49,16 @@ public static RollbarQueueController? Instance { get { - return NestedSingleInstance.TheInstance; + return RollbarInfrastructure.Instance.QueueController as RollbarQueueController; } } /// /// Prevents a default instance of the class from being created. /// - private RollbarQueueController() + internal RollbarQueueController() { - } - - /// - /// Class NestedSingleInstance. This class cannot be inherited. - /// - private sealed class NestedSingleInstance - { - /// - /// Prevents a default instance of the class from being created. - /// - private NestedSingleInstance() - { - } - - /// - /// The instance - /// - internal static readonly RollbarQueueController? TheInstance = - RollbarInfrastructure.Instance.IsInitialized ? new RollbarQueueController() - : null; + traceSource.TraceInformation($"Creating the {typeof(RollbarQueueController).Name}..."); } #endregion singleton implementation @@ -85,7 +66,8 @@ private NestedSingleInstance() /// /// The trace source /// - private static readonly TraceSource traceSource = new TraceSource(typeof(RollbarQueueController).FullName ?? "RollbarQueueController"); + private static readonly TraceSource traceSource = + new TraceSource(typeof(RollbarQueueController).FullName ?? "RollbarQueueController"); /// /// Enum PayloadTraceSources diff --git a/Rollbar/Infrastructure/_RollbarPackages.cd b/Rollbar/Infrastructure/_RollbarPackages.cd index 904bad5d..10952330 100644 --- a/Rollbar/Infrastructure/_RollbarPackages.cd +++ b/Rollbar/Infrastructure/_RollbarPackages.cd @@ -3,7 +3,7 @@ - AAAABAAAAAgAAAAAAgAAAEAAAACBAIAAAAAAQAAQAAA= + AAAABAAAAAgAAAAgAgAAAAAAAACBAIAAAAAAQAAQAAA= Infrastructure\RollbarPackageBase.cs diff --git a/Rollbar/RollbarDataScrubbingHelper.cs b/Rollbar/RollbarDataScrubbingHelper.cs index 29e82943..a1882f64 100644 --- a/Rollbar/RollbarDataScrubbingHelper.cs +++ b/Rollbar/RollbarDataScrubbingHelper.cs @@ -1,6 +1,7 @@ namespace Rollbar { using System; + using System.Diagnostics; using System.Linq; using System.Collections.Generic; @@ -14,9 +15,14 @@ /// public class RollbarDataScrubbingHelper { + private static readonly TraceSource traceSource = + new TraceSource(typeof(RollbarDataScrubbingHelper).FullName ?? "RollbarDataScrubbingHelper"); #region singleton implementation + private static readonly Lazy lazySingleton = + new Lazy(() => new RollbarDataScrubbingHelper()); + /// /// Gets the instance. /// @@ -25,34 +31,16 @@ public static RollbarDataScrubbingHelper Instance { get { - return NestedSingleInstance.TheInstance; + return lazySingleton.Value; } } /// - /// Prevents a default instance of the class from being created. + /// Prevents a default instance of the class from being created. /// private RollbarDataScrubbingHelper() { - } - - /// - /// Class NestedSingleInstance. This class cannot be inherited. - /// - private sealed class NestedSingleInstance - { - /// - /// Prevents a default instance of the class from being created. - /// - private NestedSingleInstance() - { - } - - /// - /// The instance - /// - internal static readonly RollbarDataScrubbingHelper TheInstance = - new RollbarDataScrubbingHelper(); + traceSource.TraceInformation($"Creating the {typeof(RollbarDataScrubbingHelper).Name}..."); } #endregion singleton implementation diff --git a/Rollbar/RollbarInfrastructure.cs b/Rollbar/RollbarInfrastructure.cs index 533d79c1..917c6fd7 100644 --- a/Rollbar/RollbarInfrastructure.cs +++ b/Rollbar/RollbarInfrastructure.cs @@ -20,22 +20,35 @@ /// /// /// - public class RollbarInfrastructure + public sealed class RollbarInfrastructure : IRollbarInfrastructure , IDisposable { - private static readonly TraceSource traceSource = new TraceSource(typeof(RollbarInfrastructure).FullName ?? "RollbarInfrastructure"); + private static readonly TraceSource traceSource = + new TraceSource(typeof(RollbarInfrastructure).FullName ?? "RollbarInfrastructure"); - internal readonly TimeSpan _sleepInterval = TimeSpan.FromMilliseconds(25); + internal readonly TimeSpan _sleepInterval = + TimeSpan.FromMilliseconds(25); private readonly object _syncLock = new object(); - private bool _isInitialized = false; - private IRollbarInfrastructureConfig? _config; + private readonly Lazy _lazyQueueController = + new Lazy(() => new RollbarQueueController()); + + private readonly Lazy _lazyTelemetryCollector = + new Lazy(() => new RollbarTelemetryCollector()); + + private readonly Lazy _lazyConnectivityMonitor = + new Lazy(() => new RollbarConnectivityMonitor()); + + #region singleton implementation + private static readonly Lazy lazySingleton = + new Lazy(() => new RollbarInfrastructure()); + /// /// Gets the instance. /// @@ -44,7 +57,7 @@ public static RollbarInfrastructure Instance { get { - return NestedSingleInstance.TheInstance; + return lazySingleton.Value; } } @@ -56,25 +69,6 @@ private RollbarInfrastructure() traceSource.TraceInformation($"Creating the {typeof(RollbarInfrastructure).Name}..."); } - /// - /// Class NestedSingleInstance. This class cannot be inherited. - /// - private sealed class NestedSingleInstance - { - /// - /// Prevents a default instance of the class from being created. - /// - private NestedSingleInstance() - { - } - - /// - /// The instance - /// - internal static readonly RollbarInfrastructure TheInstance = - new RollbarInfrastructure(); - } - #endregion singleton implementation /// @@ -85,7 +79,9 @@ public bool IsInitialized { get { - return this._isInitialized; + return (this._lazyQueueController.IsValueCreated + && this._lazyTelemetryCollector.IsValueCreated + && this._lazyConnectivityMonitor.IsValueCreated); } } @@ -97,7 +93,12 @@ public IRollbarQueueController? QueueController { get { - return RollbarQueueController.Instance; + if (!this._lazyQueueController.IsValueCreated) + { + return null; + } + + return this._lazyQueueController.Value; } } @@ -109,7 +110,12 @@ public IRollbarTelemetryCollector? TelemetryCollector { get { - return RollbarTelemetryCollector.Instance; + if (!this._lazyTelemetryCollector.IsValueCreated) + { + return null; + } + + return this._lazyTelemetryCollector.Value; } } @@ -121,7 +127,12 @@ public IRollbarConnectivityMonitor? ConnectivityMonitor { get { - return RollbarConnectivityMonitor.Instance; + if (!this._lazyConnectivityMonitor.IsValueCreated) + { + return null; + } + + return _lazyConnectivityMonitor.Value; } } @@ -150,10 +161,12 @@ public IRollbarInfrastructureConfig Config public void Init(IRollbarInfrastructureConfig config) { Assumption.AssertNotNull(config, nameof(config)); + Assumption.AssertNotNull(RollbarInfrastructure.Instance, nameof(RollbarInfrastructure.Instance)); + Assumption.AssertFalse(RollbarInfrastructure.Instance.IsInitialized, nameof(RollbarInfrastructure.Instance.IsInitialized)); lock(this._syncLock) { - if(this._isInitialized) + if(this.IsInitialized) { string msg = $"{typeof(RollbarInfrastructure).Name} can not be initialized more than once!"; traceSource.TraceInformation(msg); @@ -163,28 +176,20 @@ public void Init(IRollbarInfrastructureConfig config) ); } - this._config = config; - this.ValidateConfiguration(); - this._config.Reconfigured += _config_Reconfigured; - - this._isInitialized = true; - // now, since the basic infrastructure seems to be good and initialized, // let's initialize all the dependent services of the infrastructure: try { - RollbarQueueController.Instance!.Init(config); - RollbarTelemetryCollector.Instance!.Init(config.RollbarTelemetryOptions); - // NOTE: RollbarConfig - // - init ConnectivityMonitor service as needed - // NOTE: It should be sufficient to make ConnectivityMonitor as internal class - // It is only used by RollbarClient and RollbarQueueController that are - // already properly deactivated in single-threaded environments. + this._config = config; + this.ValidateConfiguration(); + this._config.Reconfigured += _config_Reconfigured; + this._lazyQueueController.Value.Init(config); + this._lazyTelemetryCollector.Value.Init(config.RollbarTelemetryOptions); + _ = this._lazyConnectivityMonitor.Value; + //Assumption.AssertTrue(RollbarInfrastructure.Instance.IsInitialized, nameof(RollbarInfrastructure.Instance.IsInitialized)); } catch(Exception ex) { - this._isInitialized = false; - throw new RollbarException( InternalRollbarError.InfrastructureError, "Exception while initializing the internal services!", @@ -197,8 +202,9 @@ public void Init(IRollbarInfrastructureConfig config) private void ValidateConfiguration() { - if(this._isInitialized) + if(this.IsInitialized) { + // nice short-cut: return; } @@ -250,7 +256,7 @@ private void CompleteProcessing() /// Releases unmanaged and - optionally - managed resources. /// /// true to release both managed and unmanaged resources; false to release only unmanaged resources. - protected virtual void Dispose(bool disposing) + private void Dispose(bool disposing) { if(!disposedValue) { diff --git a/Rollbar/RollbarLocator.cs b/Rollbar/RollbarLocator.cs index e8e58992..0f3663c4 100644 --- a/Rollbar/RollbarLocator.cs +++ b/Rollbar/RollbarLocator.cs @@ -1,32 +1,39 @@ namespace Rollbar { + using System; + + using System.Diagnostics; /// /// Singleton-like locator of the single shared instance of IRollbar component. /// - public class RollbarLocator + public sealed class RollbarLocator { + private static readonly TraceSource traceSource = + new TraceSource(typeof(RollbarLocator).FullName ?? "RollbarLocator"); + + #region singleton implementation + + private static readonly Lazy lazySingleton = + new Lazy(() => RollbarFactory.CreateNew()); + /// /// Gets the singleton-like IRollbar instance. /// - /// - /// The single shared IRollbar instance. - /// + /// The instance. public static IRollbar RollbarInstance { get { - return NestedSingleInstance.Instance; + return lazySingleton.Value; } } - private sealed class NestedSingleInstance + private RollbarLocator() { - private NestedSingleInstance() - { - } - - internal static readonly IRollbar Instance = RollbarFactory.CreateNew(); + traceSource.TraceInformation($"Creating the {typeof(RollbarLocator).Name}..."); } + + #endregion singleton implementation } } diff --git a/Rollbar/Telemetry/RollbarTelemetryCollector.cs b/Rollbar/Telemetry/RollbarTelemetryCollector.cs index b2ae7072..4331b879 100644 --- a/Rollbar/Telemetry/RollbarTelemetryCollector.cs +++ b/Rollbar/Telemetry/RollbarTelemetryCollector.cs @@ -10,48 +10,33 @@ /// /// Implements Rollbar telemetry collector service. /// - internal class RollbarTelemetryCollector + internal sealed class RollbarTelemetryCollector : IRollbarTelemetryCollector , IDisposable { private static readonly TraceSource traceSource = new TraceSource(typeof(RollbarTelemetryCollector).FullName ?? "RollbarTelemetryCollector"); - + #region singleton implementation /// /// Gets the instance. /// - /// - /// The instance. - /// + /// The instance. public static RollbarTelemetryCollector? Instance { get { - return NestedSingleInstance.TheInstance; + return RollbarInfrastructure.Instance.TelemetryCollector as RollbarTelemetryCollector; } } /// /// Prevents a default instance of the class from being created. /// - private RollbarTelemetryCollector() + internal RollbarTelemetryCollector() { - } - - private sealed class NestedSingleInstance - { - private NestedSingleInstance() - { - } - - /// - /// The singleton-like instance of the service. - /// - internal static readonly RollbarTelemetryCollector? TheInstance = - RollbarInfrastructure.Instance.IsInitialized ? new RollbarTelemetryCollector() - : null; + traceSource.TraceInformation($"Creating the {typeof(RollbarTelemetryCollector).Name}..."); } #endregion singleton implementation @@ -318,7 +303,7 @@ private void KeepCollectingTelemetry(object? data) /// Releases unmanaged and - optionally - managed resources. /// /// true to release both managed and unmanaged resources; false to release only unmanaged resources. - protected virtual void Dispose(bool disposing) + private void Dispose(bool disposing) { if (!disposedValue) { diff --git a/Rollbar/Telemetry/_Telemetry.cd b/Rollbar/Telemetry/_Telemetry.cd index bc3103c0..58f1e9a0 100644 --- a/Rollbar/Telemetry/_Telemetry.cd +++ b/Rollbar/Telemetry/_Telemetry.cd @@ -1,68 +1,36 @@  - - - - - - - - - Telemetry\TelemetryCollector.cs - - - - - AAAIAYAAEiAgAgABAAAAUACAAAAIgAIASBBQAiIAAAA= - Telemetry\TelemetryCollector.cs - - - - - - - AAAAAAAAQAAAABAAAAACAAACAAAAAAAQAAACABAAAAA= - Telemetry\TelemetryConfig.cs - - - - - + + AABAAAAAAAAkAgAAEAAAEAAAAAAABAAAAAIAAAAIAAA= Telemetry\TelemetryQueue.cs - - + + AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAA= Telemetry\TelemetryUtility.cs - - - - AAAAAAAAEgAgAgAAAAAAUAAAAAAAAAAAABBQAAAAAAA= - Telemetry\ITelemetryCollector.cs - - - - + + - AAAAAAAAAAAAABAAAAACAAAAAAAAAAAAAAACABAAAAA= - Telemetry\ITelemetryConfig.cs + AAAIAIAAEiAgAgABAAAAUACAAAAIgAIASBBSAiIAABA= + Telemetry\RollbarTelemetryCollector.cs - - - + + + + AAAAAAAABAAAAAABAAAAAAgAAAAAAAAAgAAAAAEAAAA= Telemetry\TelemetryAutoCollectionSettings.cs - + AAAAAAAAQAAAAQAAAAAAAAAACAgAAAAAAAAAAAUAQAA= DTOs\TelemetryType.cs diff --git a/Rollbar/_Rollbar.cd b/Rollbar/_Rollbar.cd index 886c254c..9ff7b4c4 100644 --- a/Rollbar/_Rollbar.cd +++ b/Rollbar/_Rollbar.cd @@ -5,15 +5,8 @@ - - - - RollbarLocator.cs - - - - AAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= + AAAAAAQAAAAAAgABAAAAAAAAAAAAAAAAAAAAAAAAAAA= RollbarLocator.cs @@ -55,20 +48,15 @@ - + - + - RollbarQueueController.cs - - - - - RollbarQueueController.cs + Infrastructure\RollbarQueueController.cs @@ -80,15 +68,8 @@ - - - - RollbarInfrastructure.cs - - - - AAAIAAAQAiAgAAEhAAAAAAAAAIAAgAIAYAICBggAAAA= + AAAIAAAAAiAgAgEhAAAAAAAAIIABgAIAYAICBggAAAA= RollbarInfrastructure.cs @@ -98,13 +79,6 @@ - - - - Telemetry\RollbarTelemetryCollector.cs - - - AAAIAIAAEiAgAgABAAAAUACAAAAIgAIASBBSAiIAABA= Telemetry\RollbarTelemetryCollector.cs diff --git a/Rollbar/_RollbarConfig.cd b/Rollbar/_RollbarConfig.cd index 3a585c65..4554aaa6 100644 --- a/Rollbar/_RollbarConfig.cd +++ b/Rollbar/_RollbarConfig.cd @@ -24,7 +24,7 @@ - AAAAAAAAAAAAAIAAAAAAAAAAAAAAAAIIAAAEBAAAAAA= + AAAAAAAAAAAAAIAAAAAAAAAAAAAAAAIIAAAEBAQAAAA= IRollbarDeveloperOptions.cs diff --git a/Rollbar/_RollbarInfrastructure.cd b/Rollbar/_RollbarInfrastructure.cd index 487df3b6..bd9d114f 100644 --- a/Rollbar/_RollbarInfrastructure.cd +++ b/Rollbar/_RollbarInfrastructure.cd @@ -8,11 +8,6 @@ - - - Infrastructure\RollbarQueueController.cs - - Infrastructure\RollbarQueueController.cs @@ -30,15 +25,8 @@ - - - - RollbarInfrastructure.cs - - - - AAAIAAAQAiAgAAEhAAAAAAAAAIAAgAIAYAICBggAAAA= + AAAIAAAAAiAgAgEhAAAAAAAAIIABgAIAYAICBggAAAA= RollbarInfrastructure.cs @@ -51,13 +39,6 @@ - - - - Telemetry\RollbarTelemetryCollector.cs - - - AAAIAIAAEiAgAgABAAAAUACAAAAIgAIASBBSAiIAABA= Telemetry\RollbarTelemetryCollector.cs diff --git a/Rollbar/_RollbarLogger.cd b/Rollbar/_RollbarLogger.cd index 28db75d9..9ece4fe2 100644 --- a/Rollbar/_RollbarLogger.cd +++ b/Rollbar/_RollbarLogger.cd @@ -5,15 +5,8 @@ - - - - RollbarLocator.cs - - - - AAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= + AAAAAAQAAAAAAgABAAAAAAAAAAAAAAAAAAAAAAAAAAA= RollbarLocator.cs diff --git a/Rollbar/_RollbarPackagingStrategies.cd b/Rollbar/_RollbarPackagingStrategies.cd index c7973219..6f2ad34f 100644 --- a/Rollbar/_RollbarPackagingStrategies.cd +++ b/Rollbar/_RollbarPackagingStrategies.cd @@ -4,14 +4,14 @@ AAAAJAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIAAA= - ExceptionPackage.cs + PayloadPackages\ExceptionPackage.cs - AAAABAAAAAgAAAAAAgAAAEAAAACBAIAAAAAAQAAQAAA= - RollbarPackageBase.cs + AAAABAAAAAgAAAAgAgAAAAAAAACBAIAAAAAAQAAQAAA= + Infrastructure\RollbarPackageBase.cs @@ -19,7 +19,7 @@ AAAABAAAAAAAAAAAAgAAAAAAAAAAAAAAgAAAQACwAAA= - RollbarPackageDecoratorBase.cs + Infrastructure\RollbarPackageDecoratorBase.cs @@ -27,49 +27,49 @@ AAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAgAAA= - PersonPackageDecorator.cs + PayloadPackageDecorators\PersonPackageDecorator.cs IAAAJAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAA= - MessagePackage.cs + PayloadPackages\MessagePackage.cs AAAABAAAAAAACAAAAAAAAAQAAAAAAAAAAAACAAAAAAA= - BodyPackage.cs + PayloadPackages\BodyPackage.cs AAAABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIAAAAAA= - DataPackage.cs + PayloadPackages\DataPackage.cs AAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAgAAA= - CustomKeyValuePackageDecorator.cs + PayloadPackageDecorators\CustomKeyValuePackageDecorator.cs AAAAJAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAIAAAA= - ObjectPackage.cs + PayloadPackages\ObjectPackage.cs - AAAAAAAAAAAAAAAAAAAAAAAAAAABQAAAAAACAAAgABA= - HttpRequestMessagePackageDecorator.cs + AAAAAAAAAAAAAAABAAAAAAAAAAABQAAAAAACAAAgABA= + PayloadPackageDecorators\HttpRequestMessagePackageDecorator.cs diff --git a/Samples/Sample.VBNet.ConsoleApp/App.config b/Samples/Sample.VBNet.ConsoleApp/App.config index bcb2ae2d..a58a46ef 100644 --- a/Samples/Sample.VBNet.ConsoleApp/App.config +++ b/Samples/Sample.VBNet.ConsoleApp/App.config @@ -1,13 +1,13 @@ - + - + - - + + diff --git a/Samples/Sample.VBNet.ConsoleApp/My Project/Resources.Designer.vb b/Samples/Sample.VBNet.ConsoleApp/My Project/Resources.Designer.vb index 9608190f..b64fba16 100644 --- a/Samples/Sample.VBNet.ConsoleApp/My Project/Resources.Designer.vb +++ b/Samples/Sample.VBNet.ConsoleApp/My Project/Resources.Designer.vb @@ -22,7 +22,7 @@ Namespace My.Resources ''' ''' A strongly-typed resource class, for looking up localized strings, etc. ''' - _ diff --git a/Samples/Sample.VBNet.ConsoleApp/My Project/Settings.Designer.vb b/Samples/Sample.VBNet.ConsoleApp/My Project/Settings.Designer.vb index 1e3cf95f..9eeb56e9 100644 --- a/Samples/Sample.VBNet.ConsoleApp/My Project/Settings.Designer.vb +++ b/Samples/Sample.VBNet.ConsoleApp/My Project/Settings.Designer.vb @@ -15,7 +15,7 @@ Option Explicit On Namespace My _ Partial Friend NotInheritable Class MySettings Inherits Global.System.Configuration.ApplicationSettingsBase diff --git a/SdkCommon.csproj b/SdkCommon.csproj index 161afa07..6786317d 100644 --- a/SdkCommon.csproj +++ b/SdkCommon.csproj @@ -24,14 +24,14 @@ - 5.1.1 + 5.1.2 false - - fix: resolve GH #615 - ConnectivityMonitor tests wrong thing + fix: resolve #623 - NullReference exception while initializing RollbarInfrastructure - +