Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 pixel misalignment of title field in AdminThemeUikit #94

Closed
Toutouwai opened this issue May 18, 2018 · 2 comments
Closed

1 pixel misalignment of title field in AdminThemeUikit #94

Toutouwai opened this issue May 18, 2018 · 2 comments

Comments

@Toutouwai
Copy link

Toutouwai commented May 18, 2018

AOS causes a 1 pixel misalignment of the title field in AdminThemeUikit. It becomes noticeable when the width of the title field is not 100% (i.e. it has a neighbouring inputfield on the same row).

2018-05-18_145438

The title field is 1 pixel taller than it should be. And although it's not noticeable in the screenshot above (and hardly matters) it's also 1 pixel wider than it should be.

The issue seems to be related to the position: relative that is added to both the .Inputfield element and the .InputfieldContent element. I think those styles are added to support the case toggle button, but the styles are actually added regardless of whether that option is enabled in AOS.

Not sure of a good solution. Perhaps the case toggle option could also add a containing div around the button and then the button could be positioned relative to that div rather than changing the position property of .Inputfield and .InputfieldContent?

@rolandtoth
Copy link
Owner

I've removed position: relative (also from the inputfield wrapper) and fixed this with some CSS trickery. Looks OK in all 3 admin themes here.

@Toutouwai
Copy link
Author

Thanks.

Looks like position: relative is going to be a headache with inputfields in AdminThemeUikit: processwire/processwire-issues#602 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants