Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit helpful errors when file system access fails rather than just calling unwrap. #932

Open
Dekkonot opened this issue Jun 24, 2024 · 0 comments
Open

Emit helpful errors when file system access fails rather than just calling unwrap. #932

Dekkonot opened this issue Jun 24, 2024 · 0 comments
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. status: ready for work Ready to go! We would accept a PR to do this. type: tech debt Internal work that needs to happen

Comments

@Dekkonot
Copy link
Member

There are a huge variety of places where Rojo just assumes it can access a file or folder, so we call unwrap on IO operations. We should not do that, since it can fail pretty easily.

Instead, we should emit an error that's actually useful to errors and not just an OS error.
@kennethloeffler kennethloeffler added impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. type: tech debt Internal work that needs to happen status: ready for work Ready to go! We would accept a PR to do this. labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. status: ready for work Ready to go! We would accept a PR to do this. type: tech debt Internal work that needs to happen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dekkonot @kennethloeffler