Do not attempt optimize/wal on readonly main

Fixes #544
rogerbinns · Nov 20, 2024 · adebc36 · adebc36
1 parent 418bd0e
commit adebc36
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/apsw/bestpractice.py b/apsw/bestpractice.py
@@ -17,8 +17,10 @@ def connection_wal(connection: apsw.Connection) -> None:
     `described here <https://www.sqlite.org/wal.html>`__.
     """
     try:
-        connection.pragma("journal_mode", "wal")
+        if not connection.readonly("main"):
+            connection.pragma("journal_mode", "wal")
     except apsw.ReadOnlyError:
+        # journal/wal etc could still be readonly
         pass
 
 
@@ -75,8 +77,10 @@ def connection_optimize(connection: apsw.Connection) -> None:
     <https://sqlite.org/lang_analyze.html>`__.
     """
     try:
-        connection.pragma("optimize", 0x10002)
+        if not connection.readonly("main"):
+            connection.pragma("optimize", 0x10002)
     except apsw.ReadOnlyError:
+        # journal/wal etc could still be readonly
         pass
 
 

diff --git a/apsw/tests.py b/apsw/tests.py
@@ -10178,7 +10178,8 @@ def testBestPractice(self) -> None:
                 self.assertRaises(apsw.SQLError, con.execute, dqs)
 
         # can't optimize or WAL readonly databases
-        apsw.Connection(self.db.filename, flags=apsw.SQLITE_OPEN_READONLY)
+        with self.assertNoLogs():
+            apsw.Connection(self.db.filename, flags=apsw.SQLITE_OPEN_READONLY)
 
     def testExtTracing(self) -> None:
         "apsw.ext Tracing and Resource usage"