Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOSBox build problems #6

Open
dcoshea opened this issue Sep 9, 2017 · 5 comments
Open

DOSBox build problems #6

dcoshea opened this issue Sep 9, 2017 · 5 comments

Comments

@dcoshea
Copy link

dcoshea commented Sep 9, 2017

SOURCES/src/MAKEMOS.BAT includes the following code (as at 2d19bc1):

ren __*.* $$*.*
ren _*.* $*.*

When running under DOSBox 0.74, these lines result in the following errors being reported:

This is a simple version of the command, no wildcards allowed!
This is a simple version of the command, no wildcards allowed!

Obviously using real DOS to run the build should avoid these errors, although I haven't tried that yet.

@roelandjansen
Copy link
Owner

it should indeed not be triggered with normal DOS.

Now, I might as well check if freedos and PCMOS still works OK. Afaik this could be an alternative. If yes, I would suggest to make a buildenv.md that describes the "supported" environment .. elkse we could end up in having too many ways to build.

@ghost
Copy link

ghost commented Feb 3, 2019

This is a limitation of DOSBox, but their focus is games. For that reason, I don't think PC-MOS should be responsible for coping with a DOSBox limitation. If there is no objection, I will close this in a few days.

@the-grue
Copy link
Collaborator

the-grue commented Feb 3, 2019

I use DosBox as my main development platform and work around these types of issues. Well, honestly, I don't use MAKEMOS.BAT because it doesn't do a complete build as I have mentioned elsewhere. My attempts to use the lowest common denominator in batch scripts should resolve this going forward.

See ulib/TESTCOMP.BAT. If something doesn't work because of a DosBox limitation, I call it out in the script to let the user know and how they can work around it. Of course, I can't code to everybody's favorite dev/test environment since I don't know what everybody else uses, so there is some generic helpful text output if it fails.

I don't like closing unresolved issues though, so if someone wants to patch MAKEMOS.BAT, this can be properly closed.

@ghost
Copy link

ghost commented Feb 3, 2019

Since you object, I will leave it alone. I didn't know we have a DOSBox user. You should help your fellow DOSBoxers out!

MAKEMOS is not very interesting to me either. So far I've only used a modifed subset of it to build the kernel. I can't use BIN as provided because I already have a BIN directory, so I rename the project BIN to BINMOS.

Because of so many local environment differences, I don't think we should have a master build script. Instead, describe in Engilsh the required steps, and let people translate that to a batch file for their own local environment. Maybe offer a sample batch file to get them started, but without trying to fix it every time someone complains.

@ghost
Copy link

ghost commented Feb 4, 2019

Too many words in the title, which are duplicated in the thread. Thus my edit to condense it. If someone is unhappy with the edit, here's the original, you can change it back:

MAKEMOS.BAT under DOSBox 0.74 reports "This is a simple version of the command, no wildcards allowed!"

@ghost ghost changed the title MAKEMOS.BAT under DOSBox 0.74 reports "This is a simple version of the command, no wildcards allowed!" DOSBox build problems Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants