Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build depends on c:\tmp existing #5

Closed
dcoshea opened this issue Sep 9, 2017 · 3 comments
Closed

Build depends on c:\tmp existing #5

dcoshea opened this issue Sep 9, 2017 · 3 comments

Comments

@dcoshea
Copy link

dcoshea commented Sep 9, 2017

SOURCES/src/MAKEMOS.BAT includes the following code (as at 2d19bc1):

set TMP=c:\TMP

When I performed a build, I noticed the following error fly by (manually transcribed, so apologies for any errors):

link mosfront +mosint13 [...]
Ndmake:  warning -- cannot open response file `c:\TMP\mk003683'.

*** Error code 1

Since MAKEMOS.BAT causes there to be a requirement for this directory to exist, it'd be nice if it checked for its existence too.

Alternatively, or in addition to this, README.md could note that you need to create that directory before building.

I'll try to file a PR to add these sometime, but I'm not sure when I'll get around to it.

@roelandjansen
Copy link
Owner

good catch.

I haven't created a virtual env to build it again myself, nor thought of a way to pull or push changes from there.

@dcoshea
Copy link
Author

dcoshea commented Sep 9, 2017

I haven't created a virtual env to build it again myself, nor thought of a way to pull or push changes from there.

[Edited again: I moved my response to new issue #8 since it's off-topic and deserves further discussion]

@andrewbird
Copy link
Contributor

Current MAKEMOS.BAT does mkdir %TMP% after setting it so this issue can probably be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants