-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository contains intermediate _*.SYS #11
Comments
After #37 was merged these are no longer in the build directory, so I believe this can be closed. |
I'll second that. |
closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As at 2d19bc1,
SOURCES/src/mos5src
contains a number of files which appear to be redundant intermediate build artefacts.For each of those files, a corresponding file exists in the same directory with 1-2 leading underscores replaced with
$
, and that corresponding file is identical. The only exception is_SERIAL.SYS
whose corresponding identical file is called$$SERIAL.SYS
(i.e. one underscore is replaced with two dollar signs).Also, the corresponding
$*.SYS
versions are inSHIPMOS/SHIPMOS.ZIP
(file content comparisons were not performed here), confirming that the$*.SYS
filenames are used for shipping whereas the_*.SYS
filenames are just intermediate build artefacts. There are two exceptions to this:$KBUK.SYS
is not present inSHIPMOS/SHIPMOS.ZIP
, which instead contains two files$KBUK3.SYS
and$KBUK4.SYS
; and$$SERIAL.SYS
, is not present inSHIPMOS/SHIPMOS.ZIP
, which contains a corresponding filename with only one dollar sign.These exceptions don't invalidate the assumption that the
_*.SYS
files are intermediate build artefacts.Given the above, it seems like the files whose names are listed above don't belong in the repository as they are intermediate build products, and once you run
MAKEMOS.BAT
and it performs the renaming steps (see issues #6 and #7) those files should all disappear, resulting ingit status
showing those files as having been deleted.The text was updated successfully, but these errors were encountered: