Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review: Demultiplexing, Assignment the First: Pseudocode #2

Open
Dovezella opened this issue Jul 31, 2023 · 0 comments
Open

Peer Review: Demultiplexing, Assignment the First: Pseudocode #2

Dovezella opened this issue Jul 31, 2023 · 0 comments

Comments

@Dovezella
Copy link

  • To start, I really like the build of your reverse complement function, especially using a dictionary to do that.
  • I also really like how you laid out the plans for your code here. You state all the main aspects which you want your script to do, and it has that flow/indentation.
  • I do think that it is currently a little vague in how you plan on doing some of those aspects in your script. I assume you will be going line by line through the files, but I'm curious how you plan to record/gather each record (like maybe a particular data structure and where you might call that). The reverse comp function will definitely need to be used so that is great! Just where exactly do you plan on using it?
  • How do you plan on comparing indices to the known barcodes?
  • How do you plan on appending the indices to the headers for the write out files?
  • I really like your idea for the boolean AND statement at the end, that will be useful.
  • How do you plan on writing out to a specific file? There will be a minimum of 52 write out files, and it might be an onerous task to type out all of them.
  • So far it is great though and I see you have the main ideas out there! I hope these comments and questions will be useful to helping flush it out more. Good job!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant