From c75477aab6744fda6a9e056d2ef7a469e0ea2f85 Mon Sep 17 00:00:00 2001
From: Paul Stoellberger <pstoellberger@gmail.com>
Date: Wed, 18 Jan 2012 21:28:50 +0000
Subject: [PATCH] some improvements to the last commit

git-svn-id: https://olap4j.svn.sourceforge.net/svnroot/olap4j/trunk@488 c6a108a4-781c-0410-a6c6-c2d559e19af0
---
 src/org/olap4j/driver/xmla/XmlaOlap4jCatalog.java    | 2 +-
 src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/org/olap4j/driver/xmla/XmlaOlap4jCatalog.java b/src/org/olap4j/driver/xmla/XmlaOlap4jCatalog.java
index f9f65d2..4a71efc 100644
--- a/src/org/olap4j/driver/xmla/XmlaOlap4jCatalog.java
+++ b/src/org/olap4j/driver/xmla/XmlaOlap4jCatalog.java
@@ -154,7 +154,7 @@ public String getName() {
         return name;
     }
     
-    public List<String> getAvailableRoles() {
+    protected List<String> getAvailableRoles() {
     	return roles;
     }
 
diff --git a/src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java b/src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java
index 5df85e0..29e6966 100644
--- a/src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java
+++ b/src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java
@@ -126,7 +126,7 @@ abstract class XmlaOlap4jConnection implements OlapConnection {
      * calls as part of &lt;PropertyList/&gt;.<br />
      * Can be passed to connection via connection string properties.
      */
-    private Properties databaseProperties;
+    private final Properties databaseProperties;
 
     private boolean autoCommit;
     private boolean readOnly;
@@ -740,7 +740,7 @@ public String getRoleName() {
     }
 
     public List<String> getAvailableRoleNames() {
-        Set<String> roleNames = new HashSet<String>();
+        Set<String> roleNames = new LinkedHashSet<String>();
         try {
             for (Catalog catalog : getOlapCatalogs()) {
                 List<String> catalogRoles =