Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles with ' generates roc.config with syntax error #187

Open
tjamet opened this issue Jul 12, 2017 · 1 comment
Open

Titles with ' generates roc.config with syntax error #187

tjamet opened this issue Jul 12, 2017 · 1 comment

Comments

@tjamet
Copy link

tjamet commented Jul 12, 2017

To reproduce this issue, run, with roc@next:

$> roc new my-test
? Select a template rocjs/roc-template-web-app-react
ℹ Will use next as default version
✔ Downloading template
? Project name my-test
? Project description A Roc project
? Author Me
? license MIT
? Port 3000
? <title> me's project
✔ Project created

  To get started:

    cd my-test
    npm install
    npm run dev

    It will open your default browser when ready.
    You can change this by setting 'dev.browsersync.options.open' to 'false' in roc.config.js

Then you will have:

$> cat my-test/roc.config.js
module.exports = {
  settings: {
    runtime: {
      applicationName: 'me's project',
      port: 3000,
      serve: ['public', 'build/client'],
      favicon: 'favicon.png',
    },
    build: {
      reducers: 'src/redux/reducers.js',
      routes: 'src/routes/index.js',
    },
    dev: {
      browsersync: {
        options: {
          open: true,
        },
      },
    },
  },
};
@dlmr
Copy link
Member

dlmr commented Jul 12, 2017

Thanks for the bug report!

Looks like we are not escaping it right now, something we should be doing, or alternatively forbid ' from being used but that makes less sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants