Skip to content
This repository has been archived by the owner on Jan 2, 2018. It is now read-only.

Improve the error when a module has been included that requires to be run through Webpack in Node #9

Closed
dlmr opened this issue Aug 19, 2016 · 1 comment

Comments

@dlmr
Copy link
Member

dlmr commented Aug 19, 2016

If a user includes a file in their server bundle that needs to be run through Webpack they will most likley see something similar to the following.

Error: Cannot find module 'style!css!less!./font-awesome-styles!./font-awesome.config.js'

This error can be confusing and it will not be obvious at first sight that this problem is caused by a npm module that has not been run through Webpack with it's loaders.

We should try to improve this feedback. One approach can be to catch this type of error when running in development and provide a more detailed explanation about what is happening. The issue can be detected from the fact that we have ! in the path. This check will not catch problems with modules that needs to run through Babel.

@dlmr
Copy link
Member Author

dlmr commented Jan 2, 2018

This issue has been moved into the mono repository rocjs/extensions#24.

@dlmr dlmr closed this as completed Jan 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant