Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IResampler using Libzita-resampler #756

Open
gavv opened this issue Jul 13, 2024 · 2 comments
Open

Implement IResampler using Libzita-resampler #756

gavv opened this issue Jul 13, 2024 · 2 comments
Assignees
Labels
dsp Digital sound processing enhancement help wanted An important and awaited task but we have no human resources for it yet

Comments

@gavv
Copy link
Member

gavv commented Jul 13, 2024

We have IResampler interface that abstracts sample rate conversion backend. There are two major implementations: hand-crafted BuiltinResampler, and SpeexResampler that uses SpeexDSP library.

Now we need to add another implementation, ZitaResampler, that will use Libzita-resampler library (home page, documentation). The implementation would be pretty similar to SpeexResampler.

New resampler should be added to ResamplerMap. Also it should be added to the list of tested backends in test_resampler.cpp.

Note that our resampler interface allows to change frequency ratio smoothly and dynamically via set_scaling() method. This is so because we use resampler for clock drift compensation. See this page for more details on how resampler is used. See also #235 for some background and rationale.

@gavv gavv added enhancement help wanted An important and awaited task but we have no human resources for it yet dsp Digital sound processing labels Jul 13, 2024
@gavv gavv added this to Roc Toolkit Jul 13, 2024
@github-project-automation github-project-automation bot moved this to Frontlog in Roc Toolkit Jul 13, 2024
@gavv gavv moved this from Frontlog to Help wanted in Roc Toolkit Jul 13, 2024
@novertia
Copy link

Hi @gavv can I pick up this issue

@gavv
Copy link
Member Author

gavv commented Aug 19, 2024

Sure, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dsp Digital sound processing enhancement help wanted An important and awaited task but we have no human resources for it yet
Projects
Status: Help wanted
Development

No branches or pull requests

2 participants