Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement List::insert_after() #682

Closed
gavv opened this issue Jan 30, 2024 · 3 comments
Closed

Implement List::insert_after() #682

gavv opened this issue Jan 30, 2024 · 3 comments
Assignees
@veronikaro
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project enhancement help wanted An important and awaited task but we have no human resources for it yet
Milestone
0.4.0

Comments

@gavv
Copy link
Member

gavv commented Jan 30, 2024

core::List has insert_before() method.

It would be convenient to implement complementary insert_after().

New method should be covered with tests.
@gavv gavv added enhancement help wanted An important and awaited task but we have no human resources for it yet easy hacks The solution is expected to be straightforward even if you are new to the project labels Jan 30, 2024
@veronikaro
Copy link

Could you please assign me?

@gavv
Copy link
Member Author

gavv commented Feb 3, 2024

Welcome, thanks!

@veronikaro veronikaro mentioned this issue Feb 6, 2024
Merged
@gavv gavv added this to the next milestone Feb 13, 2024
gavv pushed a commit to veronikaro/roc-toolkit that referenced this issue Feb 13, 2024
@gavv
roc-streaminggh-682 Issue 682: add List::insert_after
79a4720
gavv pushed a commit that referenced this issue Feb 13, 2024
@gavv
gh-682 Issue 682: add List::insert_after
9beaeef
@gavv
Copy link
Member Author

gavv commented Feb 13, 2024

Landed.

@gavv gavv closed this as completed Feb 13, 2024
@gavv gavv added this to Roc Toolkit Jul 6, 2024
@gavv gavv moved this to Done in Roc Toolkit Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veronikaro veronikaro

Labels
easy hacks The solution is expected to be straightforward even if you are new to the project enhancement help wanted An important and awaited task but we have no human resources for it yet
Projects
Roc Toolkit
Status: Done
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@gavv @veronikaro