Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCP improvements #674

Open
3 of 13 tasks
gavv opened this issue Jan 20, 2024 · 0 comments
Open
3 of 13 tasks

RTCP improvements #674

gavv opened this issue Jan 20, 2024 · 0 comments
Labels
enhancement

Comments

@gavv
Copy link
Member

gavv commented Jan 20, 2024 •
edited
Loading

Follow-up for #14 and #675.

  • Refine packet counter calculation. On receiver, derive it from packet_count in SR, and handle 32-bit wraps. On sender, derive it from ext_first_sn and ext_last_sn, and also handle 32-bit wraps. (add rtcp::PacketCounter)
  • Add fract_loss calculation - loss ratio since last report. (add rtcp::LossEstimator)
  • Use receive timestamp (RTS) as report time when processing RTCP report.
  • Support multiple sources on sender (for cases like RaptorQ).
  • Implement rtcp::IntervalComputer (computes packet generation interval according to algorithm from RFC 3550) and use in rtcp::Communicator instead of hard-coded 200ms report interval.
  • Add sliding window to rtcp::RttEstimator. Compute moving minimum RTT, and average clock_shift based on it. Adjust communicator RTT tests to ensure that sliding window improves RTT & clock offset estimation precision.
  • Implement RTCP BYE exchange. Handle exit by signal and ask pipeline to generate BYE. Processing of BYE is already implemented.
  • Fix RTCP multicast support. If receiver RTCP endpoint is bound to multicast address, it should use Report_ToAddress instead of Report_Back mode.
  • Always collect metrics for all receivers in FeedbackMonitor. If single-receiver mode is enabled, additionally create latency tuner, otherwise just collect metrics. Needed for Metrics API #681.
  • Implement local SSRC change in FeedbackMonitor when latency goes out of bounds (to initiate session restart on remote side).
  • Add tests with real captured packets.
  • Schedule pipeline refresh() according to nearest deadline returned from RTCP.
  • Handle system clock jumps in pipeline (since it breaks RTCP).
@gavv gavv changed the title RTCP support improvements RTCP improvements Jan 23, 2024
gavv added a commit to gavv/roc-toolkit that referenced this issue Jan 30, 2024
@gavv
roc-streaminggh-674 Add receive timestamp (RTS) to packet printer
26af7d0
gavv added a commit to gavv/roc-toolkit that referenced this issue Jan 31, 2024
@gavv
roc-streaminggh-674 Fix RTCP multicast support
5936fee 
If receiver RTCP endpoint is bound to multicast address, it
now uses Report_ToAddress instead of Report_Back mode.
This was referenced Jan 31, 2024
Open
Open
gavv added a commit to gavv/roc-toolkit that referenced this issue Feb 5, 2024
@gavv
roc-streaminggh-674 Refine packet_count and fract_loss calculations
e1909c6 
- packet_count: On receiver, derive it from packet_count in SR,
  and handle 32-bit wraps. On sender, derive it from ext_first_sn
  and ext_last_sn, and also handle 32-bit wraps

- fract_loss: automatically calculate loss ratio since last report
  based on packet_count and cum_loss
gavv added a commit to gavv/roc-toolkit that referenced this issue Feb 5, 2024
@gavv
roc-streaminggh-674 Refine packet_count and fract_loss calculations
c945bff 
- packet_count: On receiver, derive it from packet_count in SR,
  and handle 32-bit wraps. On sender, derive it from ext_first_sn
  and ext_last_sn, and also handle 32-bit wraps

- fract_loss: automatically calculate loss ratio since last report
  based on packet_count and cum_loss
@baranovmv baranovmv mentioned this issue Jun 30, 2024
Closed
21 tasks
@gavv gavv added this to Roc Toolkit Jul 6, 2024
@gavv gavv moved this to Frontlog in Roc Toolkit Jul 6, 2024
@gavv gavv mentioned this issue Jul 8, 2024
Merged
@gavv gavv moved this from Frontlog to In work in Roc Toolkit Dec 4, 2024
baranovmv added a commit to baranovmv/roc-toolkit that referenced this issue Dec 4, 2024
@baranovmv
Preparation for E2E latency tuning
4fd3012 
In order to be able to tune receiver's latency
relying on timestamp mapping that we get from
RTCP feedback, and UDP::Receive_timestamp,
adding these features:

* roc-streaminggh-674: Use receive timestamp (RTS) as report time
  when processing RTCP report;

* RTT dumping for debugging (csvplotter ts_offset branch);

* SCHED_RR for network io thread (run with root privs).
baranovmv added a commit to baranovmv/roc-toolkit that referenced this issue Dec 4, 2024
@baranovmv
Preparation for E2E latency tuning
73448d9 
In order to be able to tune receiver's latency
relying on timestamp mapping that we get from
RTCP feedback, and UDP::Receive_timestamp,
adding these features:

* roc-streaminggh-674: Use receive timestamp (RTS) as report time
  when processing RTCP report;

* RTT dumping for debugging (csvplotter ts_offset branch);

* SCHED_RR for network io thread (run with root privs).
@baranovmv baranovmv mentioned this issue Dec 4, 2024
Open
baranovmv added a commit to baranovmv/roc-toolkit that referenced this issue Dec 19, 2024
@baranovmv
Preparation for E2E latency tuning
8ec4158 
In order to be able to tune receiver's latency
relying on timestamp mapping that we get from
RTCP feedback, and UDP::Receive_timestamp,
adding these features:

* roc-streaminggh-674: Use receive timestamp (RTS) as report time
  when processing RTCP report;

* RTT dumping for debugging (csvplotter ts_offset branch);

* SCHED_RR for network io thread (run with root privs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Roc Toolkit
Status: In work
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavv