Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect system dark theme #57

Open
q234rty opened this issue Feb 6, 2023 · 10 comments
Open

Respect system dark theme #57

q234rty opened this issue Feb 6, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@q234rty
Copy link

q234rty commented Feb 6, 2023

Using this app at night hurts my eyes :)
@PauPau-Cor
Copy link
Contributor

Hi, I want to help with this, may I get it assigned please?

@ortex
Copy link
Member

ortex commented Feb 9, 2023

Hi, yeah, of course 😄

@gavv gavv added the enhancement New feature or request label Feb 9, 2023
@PauPau-Cor
Copy link
Contributor

I'm having trouble finding where the splashscreen is used, I can see the gif in the drawable resources but I don't see it used anywhere.
Could I please get some pointer as to where it is? I'm trying to change the background of it so it fits the dark theme.

@ortex
Copy link
Member

ortex commented Feb 10, 2023

splashscreen isn't used now. And splash_anim.gif was deleted. Please rebase on freshly main :)

@valeryhime
Copy link
Contributor

The splashscreen you see is the default Android splashscreen, so I guess you need to add something to styles or maybe to AndroidManifest 🤔

@PauPau-Cor
Copy link
Contributor

@ortex Sorry, still new to git, thank you for the help, managed to get it working.
@valeryhime Thank you! you were right, it was that, I didn't even know that existed because I have an older phone and I test newer features on emulator. Just had to change the style a little bit to change the background of it.

@PauPau-Cor PauPau-Cor mentioned this issue Feb 10, 2023
Closed
@gavv gavv added good first issue Good for newcomers help wanted Contributions are welcome labels May 13, 2023
@gavv
Copy link
Member

gavv commented Sep 30, 2023

Unfinished PR: #61

@gavv
Copy link
Member

gavv commented Sep 30, 2023

@PauPau-Cor Hi! Do you still have plans on this issue?

@gavv
Copy link
Member

gavv commented Oct 12, 2023

Unassigning so that someone could pick up the issue.

@q234rty
Copy link
Author

q234rty commented May 25, 2024

It's worth mentioning that the Force Dark provided by Android 10+ works pretty well with this app:

Screenshots

Screenshot_20240525-170428_Lawnchair (Debug)
Screenshot_20240525-170424_Lawnchair (Debug)

@gavv gavv removed good first issue Good for newcomers help wanted Contributions are welcome labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@valeryhime @ortex @gavv @q234rty @PauPau-Cor