Skip to content
This repository has been archived by the owner on Jun 30, 2019. It is now read-only.

Client dns packet id uses Random.int #9

Open
cfcs opened this issue Mar 9, 2019 · 1 comment
Open

Client dns packet id uses Random.int #9

cfcs opened this issue Mar 9, 2019 · 1 comment

Comments

@cfcs
Copy link
Contributor

cfcs commented Mar 9, 2019

I took a shortcut here: https://github.com/roburio/udns/blob/master/client/udns_client.ml#L20

Leaving this issue here so we don't forget about it.

EDIT: Also it's off by one (should be 0x10000):

Random.int bound returns a random integer between 0 (inclusive)
and bound (exclusive). bound must be greater than 0 and less than 2^30.
@hannesm
Copy link
Contributor

hannesm commented Jun 27, 2019

as noted in #31, there's as well weird random numbers in the server.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants