Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The proved implementation of the priority queue is slow #40

Open
dinosaure opened this issue Sep 12, 2024 · 1 comment
Open

The proved implementation of the priority queue is slow #40

dinosaure opened this issue Sep 12, 2024 · 1 comment

Comments

@dinosaure
Copy link
Contributor

Currently, from some benchmarks, it seems that the huge bottleneck is Pqueue.extract_min_exn (which re-balances the priority queue). The Domain_elt.compare is also called a lot (probably due to cancelled tasks). We should take a deeper look on the implementation.

@dinosaure
Copy link
Contributor Author

I've noticed quite a few allocations in the major heap with this implementation but with other observation tools, it seems that Miou_pqueue (the proved impl.) isn't Miou's biggest problem. There are still some interesting areas for optimisation (inlining of Vector.get, the functor doesn't allow you to inline the function compare elements, etc.). It's clearly a low priority.

I'll leave this issue open, however, if one day implementation becomes a real problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant