From cbda71c2b36672f694aa62f3511a03b1784b8a8b Mon Sep 17 00:00:00 2001 From: Brezak Date: Mon, 13 May 2024 20:26:41 +0200 Subject: [PATCH] Determine msrv for every standalone bevy_* crate. (#13211) # Objective As was pointed out in #13183, `bevy_mikktspace` is missing it's msrv from it `Cargo.toml`. This promted me to check the msrv of every `bevy_*` crate. Closes #13183. ## Solution - Call `cargo check` with different rust versions on every bevy crate until it doesn't complain. - Write down the rust version `cargo check` started working. ## Testing - Install `cargo-msrv`. - Run `cargo msrv verify`. - Rejoice. --- ## Changelog Every published bevy crate now specifies a MSRV. If your rust toolchain isn't at least version `1.77.0` You'll likely not be able to compile most of bevy. ## Migration Guide If your rust toolchain is bellow version`1.77.0, update. --- crates/bevy_color/Cargo.toml | 1 + crates/bevy_core/Cargo.toml | 1 - crates/bevy_ecs/Cargo.toml | 1 + crates/bevy_math/Cargo.toml | 1 + crates/bevy_mikktspace/Cargo.toml | 1 + crates/bevy_mikktspace/README.md | 2 +- crates/bevy_reflect/Cargo.toml | 1 + 7 files changed, 6 insertions(+), 2 deletions(-) diff --git a/crates/bevy_color/Cargo.toml b/crates/bevy_color/Cargo.toml index 76d6ce4d312df..a7136770b691a 100644 --- a/crates/bevy_color/Cargo.toml +++ b/crates/bevy_color/Cargo.toml @@ -7,6 +7,7 @@ homepage = "https://bevyengine.org" repository = "https://github.com/bevyengine/bevy" license = "MIT OR Apache-2.0" keywords = ["bevy", "color"] +rust-version = "1.76.0" [dependencies] bevy_math = { path = "../bevy_math", version = "0.14.0-dev" } diff --git a/crates/bevy_core/Cargo.toml b/crates/bevy_core/Cargo.toml index bbf51137c7671..0af854725fd77 100644 --- a/crates/bevy_core/Cargo.toml +++ b/crates/bevy_core/Cargo.toml @@ -8,7 +8,6 @@ repository = "https://github.com/bevyengine/bevy" license = "MIT OR Apache-2.0" keywords = ["bevy"] - [dependencies] # bevy bevy_app = { path = "../bevy_app", version = "0.14.0-dev", features = [ diff --git a/crates/bevy_ecs/Cargo.toml b/crates/bevy_ecs/Cargo.toml index 3b7c1640a31af..8b7eee80981a0 100644 --- a/crates/bevy_ecs/Cargo.toml +++ b/crates/bevy_ecs/Cargo.toml @@ -8,6 +8,7 @@ repository = "https://github.com/bevyengine/bevy" license = "MIT OR Apache-2.0" keywords = ["ecs", "game", "bevy"] categories = ["game-engines", "data-structures"] +rust-version = "1.77.0" [features] trace = [] diff --git a/crates/bevy_math/Cargo.toml b/crates/bevy_math/Cargo.toml index 268f457719271..a1e362b56f574 100644 --- a/crates/bevy_math/Cargo.toml +++ b/crates/bevy_math/Cargo.toml @@ -7,6 +7,7 @@ homepage = "https://bevyengine.org" repository = "https://github.com/bevyengine/bevy" license = "MIT OR Apache-2.0" keywords = ["bevy"] +rust-version = "1.68.2" [dependencies] glam = { version = "0.27", features = ["bytemuck"] } diff --git a/crates/bevy_mikktspace/Cargo.toml b/crates/bevy_mikktspace/Cargo.toml index e11ecdc163e48..aec04e9505d47 100644 --- a/crates/bevy_mikktspace/Cargo.toml +++ b/crates/bevy_mikktspace/Cargo.toml @@ -13,6 +13,7 @@ homepage = "https://bevyengine.org" repository = "https://github.com/bevyengine/bevy" license = "Zlib AND (MIT OR Apache-2.0)" keywords = ["bevy", "3D", "graphics", "algorithm", "tangent"] +rust-version = "1.76.0" [dependencies] glam = "0.27" diff --git a/crates/bevy_mikktspace/README.md b/crates/bevy_mikktspace/README.md index 7ac119d674ce2..cb497c981aa99 100644 --- a/crates/bevy_mikktspace/README.md +++ b/crates/bevy_mikktspace/README.md @@ -10,7 +10,7 @@ This is a fork of [https://github.com/gltf-rs/mikktspace](https://github.com/glt Port of the [Mikkelsen Tangent Space Algorithm](https://en.blender.org/index.php/Dev:Shading/Tangent_Space_Normal_Maps) reference implementation. -Requires at least Rust 1.52.1. +Requires at least Rust 1.76.0. ## Examples diff --git a/crates/bevy_reflect/Cargo.toml b/crates/bevy_reflect/Cargo.toml index 7bce663922621..f23f2387656bd 100644 --- a/crates/bevy_reflect/Cargo.toml +++ b/crates/bevy_reflect/Cargo.toml @@ -7,6 +7,7 @@ homepage = "https://bevyengine.org" repository = "https://github.com/bevyengine/bevy" license = "MIT OR Apache-2.0" keywords = ["bevy"] +rust-version = "1.76.0" [features] default = ["smallvec"]