Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Fixtures #14

Closed
robproject opened this issue Aug 6, 2024 · 0 comments · Fixed by #15
Closed

Handle Fixtures #14

robproject opened this issue Aug 6, 2024 · 0 comments · Fixed by #15
Labels
enhancement New feature or request

Comments

@robproject
Copy link
Owner

Description

Fixtures on their own do not follow the same pattern as doctype or customization schema.

Testing

Make changes to a fixture and observe an error like the below. (Workflow State being the example)

Traceback (most recent call last):
  File "/Users/robir/bench/fsjd/frappe_schema_json_diff.py", line 443, in <module>
    diff.print()
  File "/Users/robir/bench/fsjd/frappe_schema_json_diff.py", line 52, in print
    self.tree = self.dict_diff(
                ^^^^^^^^^^^^^^^
  File "/Users/robir/bench/fsjd/frappe_schema_json_diff.py", line 75, in dict_diff
    for bk, bk_v in base_dict.items():
                    ^^^^^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'items'
@robproject robproject added the enhancement New feature or request label Aug 6, 2024
@robproject robproject linked a pull request Aug 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant