Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit ContentId type #1186

Open
LouieK22 opened this issue Feb 28, 2024 · 3 comments
Open

Explicit ContentId type #1186

LouieK22 opened this issue Feb 28, 2024 · 3 comments

Comments

@LouieK22
Copy link
Contributor

From #1184 (review), should we introduce an explicit ContentId type?

I'm not sure if a string template type is the best option here since the content ID can take a lot of different forms. However, a simple type ContentId = string would make the API more explicit.

@leonbee0
Copy link
Contributor

For easy changes as Dionysusnu said, it might be better to add ContentId to the Content data type.

I would say that writing with type ContentId = string is very specific.

@sasial-dev
Copy link
Contributor

This might be closed by #1318?

@Dionysusnu
Copy link
Contributor

I'd say leave it open for discussing whether the type can be refined from string.
From my preliminary testing however, the strings aren't bounded, so for example they could also just be "abc".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants