Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Departure timer times are wrong after timezone conversion #585

Closed
3 tasks done
oskari opened this issue Feb 26, 2024 · 4 comments · May be fixed by robinostlund/volkswagencarnet#269
Closed
3 tasks done

[BUG] Departure timer times are wrong after timezone conversion #585

oskari opened this issue Feb 26, 2024 · 4 comments · May be fixed by robinostlund/volkswagencarnet#269
Labels
bug Something isn't working

Comments

@oskari
Copy link

oskari commented Feb 26, 2024

Before you post a new issue - you must first check the following (and check the boxes with an "X" below)

  • 1.) Can you login using the smartphone app We Connect (not We Connect ID or We Connect GO) and interact with your car?
  • 2.) Please make sure that you can login into https://vwid.vwgroup.io/ and make sure that any "Terms and Conditions" are all checked
  • 3.) I do not have MFA enabled.

Environment

  • Volkswagencarnet release with the issue: 4.5.5
  • Last working homeassistant-volkswagencarnet release (if known): None, new feature
  • Home Assistant Core release with the issue: 2024.2.3
  • Operating environment (Home Assistant OS/Supervised/Container/Core/venv): HAOS
  • Car model and year: Passat Gte 2017
  • Country where the car was bought: Sweden?
  • Valid We Connect subscription: Yes
  • Have you verified that the We Connect service works via VW´s portal?: Yes

Describe the bug

Recently re-added feature of departure timers show wrong start times in HA compared to what is set in app or car. Doesn't seem like a timezone issue either.

Screenshots

image

image

Debug information - all JSON responses from logfile

I tried to enable the debugging but I was unable to get any logs, let me know if they're absolutely needed and I'll take an another shot on getting them enabled.
@oskari oskari added the bug Something isn't working label Feb 26, 2024
@stickpin
Copy link
Collaborator

Hi @oskari,

I've checked with multiple vehicles on my side and I am not able to reproduce the issue.
Please enable debug logging in your HA configuration.yaml and share a full log:

logger:
  default: info
  logs:
    volkswagencarnet: debug
    custom_components.volkswagencarnet: debug

Another option you share your credentials with me via email (stickpins at gmail com) and I will check it myself.

@oskari
Copy link
Author

oskari commented Feb 26, 2024 •
edited
Loading

Is this enough for debugging or do you need more or other parts of the logs?
To be clear, all the departure timers start times in HA are wrong, first one is 07.09, second is 7.59 and the third one is 7.39 while the real times are 5.30 (7.30), 6.20 (8.20) and 6.00 (8.00)

 'departureProfiles': {
    'departureProfilesStatus': {
      'value': {
        'carCapturedTimestamp': datetime.datetime(2024, 2, 13, 6, 12, 23, tzinfo = datetime.timezone.utc),
        'minSOC_pct': 90,
        'timers': [{
          'id': 1,
          'enabled': False,
          'recurringTimer': {
            'startTime': '05:30',
            'recurringOn': {
              'mondays': True,
              'tuesdays': True,
              'wednesdays': True,
              'thursdays': True,
              'fridays': True,
              'saturdays': False,
              'sundays': False
            }
          },
          'profileIDs': [1]
        }, {
          'id': 2,
          'enabled': True,
          'recurringTimer': {
            'startTime': '06:20',
            'recurringOn': {
              'mondays': True,
              'tuesdays': True,
              'wednesdays': True,
              'thursdays': True,
              'fridays': True,
              'saturdays': False,
              'sundays': False
            }
          },
          'profileIDs': [1]
        }, {
          'id': 3,
          'enabled': False,
          'recurringTimer': {
            'startTime': '06:00',
            'recurringOn': {
              'mondays': True,
              'tuesdays': True,
              'wednesdays': True,
              'thursdays': True,
              'fridays': True,
              'saturdays': False,
              'sundays': False
            }
          },
          'profileIDs': [3]
        }],
        'profiles': [{
          'id': 1,
          'name': 'Koti',
          'charging': True,
          'climatisation': True,
          'targetSOC_pct': 80,
          'maxChargeCurrentAC': 32,
          'preferredChargingTimes': [{
            'id': 1,
            'enabled': False,
            'startTime': '00:00',
            'endTime': '00:00'
          }]
        }, {
          'id': 2,
          'name': 'Koti',
          'charging': True,
          'climatisation': False,
          'targetSOC_pct': 40,
          'maxChargeCurrentAC': 5,
          'preferredChargingTimes': [{
            'id': 1,
            'enabled': True,
            'startTime': '00:00',
            'endTime': '04:00'
          }]
        }, {
          'id': 3,
          'name': 'Työ',
          'charging': False,
          'climatisation': True,
          'targetSOC_pct': 100,
          'maxChargeCurrentAC': 16,
          'preferredChargingTimes': [{
            'id': 1,
            'enabled': False,
            'startTime': '00:00',
            'endTime': '00:00'
          }]
        }]
      }
    }
  },

edit. I live in Finland, so the timezone is GMT+2 on my previous screenshot from the app

@stickpin
Copy link
Collaborator

stickpin commented Feb 26, 2024 •
edited
Loading

There is nothing wrong with your timers data. I have no explanation for this behavior.
Try to reinstall the integration, and see if it solves the issue.
If not, then the only thing I can do is to check it myself if you send me your credentials.

@oskari oskari mentioned this issue Oct 23, 2024
Open
@oskari oskari changed the title [BUG] Departure timers have wrong times [BUG] Departure timer times are wrong after timezone conversion Oct 23, 2024
@oskari
Copy link
Author

oskari commented Oct 23, 2024

Still relevant, issue found and fix suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Departure timer timezone conversion fix oskari/volkswagencarnet
2 participants
@oskari @stickpin