From 65283815ab4a98da515e5b5636dcfda85bb010ad Mon Sep 17 00:00:00 2001
From: Wade Carpenter <wade@arista.com>
Date: Fri, 6 Oct 2023 12:02:24 -0700
Subject: [PATCH 1/2] Add unit test for repo.getterImpl (and file:// scheme
 support)

Pull request #63 added support for the `file://` scheme for `fetch`.
This change adds the suggested test case to ensure that both the
baseline `http://` support and the newly-added `file://` support are
working as expected.
---
 pkg/repo/fetch_test.go | 63 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)
 create mode 100644 pkg/repo/fetch_test.go

diff --git a/pkg/repo/fetch_test.go b/pkg/repo/fetch_test.go
new file mode 100644
index 0000000..c733425
--- /dev/null
+++ b/pkg/repo/fetch_test.go
@@ -0,0 +1,63 @@
+package repo
+
+import (
+	"bytes"
+	"io"
+	"net/http"
+	"net/http/httptest"
+	"os"
+	"path"
+	"testing"
+)
+
+func TestGetter(t *testing.T) {
+	content := []byte("my file contents\n")
+	s := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
+		if r.Method != http.MethodGet {
+			t.Fatalf("wrong method, %v instead of %v", r.Method, http.MethodGet)
+		}
+		n, err := rw.Write(content)
+		if err != nil {
+			t.Fatal("write content: ", err)
+		}
+		if n != len(content) {
+			t.Fatalf("short write, %v instead of %v", n, len(content))
+		}
+	}))
+	defer s.Close()
+
+	localFile := path.Join(t.TempDir(), "contentfile")
+	if err := os.WriteFile(localFile, content, os.ModePerm); err != nil {
+		t.Fatalf("WriteFile %v failed: %v", localFile, err)
+	}
+
+	for _, tc := range []struct {
+		name string
+		url  string
+	}{
+		{
+			name: "HTTP",
+			url:  s.URL,
+		},
+		{
+			name: "local",
+			url:  "file://" + localFile,
+		},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			t.Logf("Getter.Get %v", tc.url)
+			resp, err := Getter(&getterImpl{}).Get(tc.url)
+			if err != nil {
+				t.Fatalf("Get %v: %v", tc.url, err)
+			}
+			defer resp.Body.Close()
+			recv, err := io.ReadAll(resp.Body)
+			if err != nil {
+				t.Fatalf("Read response failed: %v", err)
+			}
+			if !bytes.Equal(recv, content) {
+				t.Fatalf("Read wrong content, %v instead of %v", recv, content)
+			}
+		})
+	}
+}

From 0ec2d49f34e77170d889a1e26b06723a46d78463 Mon Sep 17 00:00:00 2001
From: Wade Carpenter <wade@arista.com>
Date: Fri, 6 Oct 2023 12:02:24 -0700
Subject: [PATCH 2/2] Add new test to pkg/repo/BUILD.bazel

Ran `make gazelle` to recalculate the go_test targets.
---
 pkg/repo/BUILD.bazel | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/pkg/repo/BUILD.bazel b/pkg/repo/BUILD.bazel
index 35162b1..d7070fd 100644
--- a/pkg/repo/BUILD.bazel
+++ b/pkg/repo/BUILD.bazel
@@ -20,7 +20,10 @@ go_library(
 
 go_test(
     name = "repo_test",
-    srcs = ["repo_test.go"],
+    srcs = [
+        "fetch_test.go",
+        "repo_test.go",
+    ],
     data = glob(["testdata/**"]),
     embed = [":repo"],
     deps = ["//pkg/api"],