-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create stricter tests for jnd2xyz() #258
Conversation
To take into account they need to have different lengths based on the chromaticity
0c393f7
to
33dbddb
Compare
It seems that there is a separate issue for dichromats, where distances returned by Since it has a separate cause, I will address it in a follow up PR and I have updated the tests to focus exclusively on the rotation aspect (via |
pkgdown workflow failure is related to r-lib/pkgdown#2802. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this — great catch, and it looks spot-on to me. Nothing to suggest in terms of changes, happy to roll this in when you're ready.
The first commit of this PR highlights the fact that distances are not preserved in the 2D case. This happens because we rotate in the 3D space and project back in 2D.
The following commits adjust
jndrot()
to rotate in the 2D plane for the 2D case, and set default foraxis1
andaxis2
in accordance with this change.TODO:
axis1
andaxis2
to follow the changes made here