Skip to content

Commit

Permalink
Don’t use repeat’s fast-path if its view contains custom elements
Browse files Browse the repository at this point in the history
Fixes aurelia#356 within sub-views
  • Loading branch information
rluba committed Mar 18, 2020
1 parent 62a4707 commit cd3e953
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/analyze-view-factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ function behaviorRequiresLifecycle(instruction) {
let name = t.elementName !== null ? t.elementName : t.attributeName;
return lifecycleOptionalBehaviors.indexOf(name) === -1 && (t.handlesAttached || t.handlesBind || t.handlesCreated || t.handlesDetached || t.handlesUnbind)
|| t.viewFactory && viewsRequireLifecycle(t.viewFactory)
|| instruction.viewFactory && viewsRequireLifecycle(instruction.viewFactory);
|| instruction.viewFactory && viewsRequireLifecycle(instruction.viewFactory)
|| instruction.initiatedByBehavior;
}

function targetRequiresLifecycle(instruction) {
Expand Down

0 comments on commit cd3e953

Please sign in to comment.