From 7693267293248b159fbde9756bfe0e7192c4f2d5 Mon Sep 17 00:00:00 2001 From: rjzamora Date: Thu, 13 Jun 2024 07:17:37 -0700 Subject: [PATCH] raise error on bad query-planning config --- dask/config.py | 2 ++ dask/dataframe/__init__.py | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/dask/config.py b/dask/config.py index 1376ae50f65..697979b7fdb 100644 --- a/dask/config.py +++ b/dask/config.py @@ -17,6 +17,8 @@ from dask.typing import no_default +_dataframe_query_planning: None | bool = None # noqa: F401 + def _get_paths(): """Get locations to search for YAML configuration files. diff --git a/dask/dataframe/__init__.py b/dask/dataframe/__init__.py index 029eef5c54a..6008c820d96 100644 --- a/dask/dataframe/__init__.py +++ b/dask/dataframe/__init__.py @@ -10,13 +10,31 @@ def _dask_expr_enabled() -> bool: import pandas as pd import dask + from dask.config import _dataframe_query_planning + + def _raise(new, old): + old_repr = "enabled" if old else "disabled" + raise ValueError( + f"The 'dataframe.query-planning' config is now set to {new}, " + "but `dask.dataframe` was first imported with query planning " + f"{old_repr}. Please make sure the query-planning config is " + "only set before `dask.dataframe` is first imported!" + ) use_dask_expr = dask.config.get("dataframe.query-planning") + if use_dask_expr is True and _dataframe_query_planning is False: + _raise(use_dask_expr, _dataframe_query_planning) + elif use_dask_expr is False and _dataframe_query_planning is True: + _raise(use_dask_expr, _dataframe_query_planning) + elif _dataframe_query_planning is not None: + return _dataframe_query_planning + if ( use_dask_expr is False or use_dask_expr is None and Version(pd.__version__).major < 2 ): + _dataframe_query_planning = False return False try: import dask_expr # noqa: F401 @@ -29,9 +47,11 @@ def _dask_expr_enabled() -> bool: """ if use_dask_expr is None: warnings.warn(msg, FutureWarning) + _dataframe_query_planning = False return False else: raise ImportError(msg) + _dataframe_query_planning = True return True