You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the new ongoing ContextDB implementation, for each event /records tuple, we have our Ctx object with all Site/Rupture/Distance parameters. Because now we might have new parameters, I added a last part of code where I query the egsim db for all registered flatfile columns and relative Ctx attributes in order to add missing attributes to Ctx, in case.
The code works, perfect. But I noticed that in the legacy code the station coordinates were set as Ctx.lats, Cts.lons (plural). Hence, now we add (redundantly?) Ctx.lat and Ctx.lon, because these are the registered attribute names in eGSIM and OpenQuake.
The question here is not only what to do, but first of all how the code actually works (this is why is maybe better to have a zoom) because logically, it should work with lat and lon (no plural, as defined in OpenQuake). Probably there is some part in smtk where the conversion tooks place, in case we might see how to simplify the code, because this might be related to another topic I would like to discuss (i.e., stick to OpenQuake names whenever possible, there are in eGSIM some patches throughout the code for normalizing almost equal names, that might be avoided for clarity)
The text was updated successfully, but these errors were encountered:
In the new ongoing
ContextDB
implementation, for each event /records tuple, we have ourCtx
object with all Site/Rupture/Distance parameters. Because now we might have new parameters, I added a last part of code where I query the egsim db for all registered flatfile columns and relativeCtx
attributes in order to add missing attributes toCtx
, in case.The code works, perfect. But I noticed that in the legacy code the station coordinates were set as
Ctx.lats
,Cts.lons
(plural). Hence, now we add (redundantly?)Ctx.lat
andCtx.lon
, because these are the registered attribute names in eGSIM and OpenQuake.The question here is not only what to do, but first of all how the code actually works (this is why is maybe better to have a zoom) because logically, it should work with lat and lon (no plural, as defined in OpenQuake). Probably there is some part in smtk where the conversion tooks place, in case we might see how to simplify the code, because this might be related to another topic I would like to discuss (i.e., stick to OpenQuake names whenever possible, there are in eGSIM some patches throughout the code for normalizing almost equal names, that might be avoided for clarity)
The text was updated successfully, but these errors were encountered: