testfactory: automatically set FinalizedAt if finalized state #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the job being created is in a finalized state, automatically set the `FinalizedAt` timestamp so that callers don't always have to do so.
brandur
approved these changes
Sep 9, 2024
|
We may also want to move this into Merging for now though! |
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
…ueue#585) If the job being created is in a finalized state, automatically set the `FinalizedAt` timestamp so that callers don't always have to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a small quality of life improvement I ran into while working on Pro stuff. I figure that by default, the
testfactorypackage should try to do the right thing and avoid requiring every field to be specified when there are reasonable defaults that could be set based on other values.In that vein, if the job being created is in a finalized state, automatically set the
FinalizedAttimestamp so that callers don't always have to do so. There was only one test that this broke, which was an easy fix.