Intermittent listener close issue popping up again

[upalsaha]

We definitely were getting hit with the previous hot loop issue mentioned in issue #248. After upgrading to 0.0.25 we did see the hot loop issue resolved with PR #246, but it seems ~15 minutes or so we're still getting the failed to send closeNotify alert issue sporadically. While the listener is able to reconnect after a while, was wondering if anyone had any updates on a resolution.

Example log:

[brandur]

Thanks for the report @upalsaha.

Ugh, unfortunately given that seems to be a driver-level error, it's a little difficult to even see exactly where that's coming from. Beyond the error, are you noticing River being degraded at all? The notifier has a built in loop that's supposed to reconnect itself even on error.

It's not released yet, but I recently did a big refactor in the notifier from top to bottom as part of #253. Can't guarantee it solves this problem, but it should be overall more stable, and at the very least will give us more specific log messages to help track down the exact location of problems.

[upalsaha]

Hey @brandur appreciate the additional context. After your original fix River behavior isn't degraded and only noticeable issue is those logs popping up (with the reconnect thankfully working). Will give the new update a go and follow up!

[brandur]

Okay great, thanks for the feedback.

Will give the new update a go and follow up!

Excellent! We'll be cutting a release soon.

[brandur]

We cut v0.1.0 with the changes.

[gabrielclimb]

should this issue be closed?

[brandur]

Probably. @upalsaha if you see any other trouble with this, okay to reopen and discuss, but closing for now.