Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisiting handholdJS #3

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Revisiting handholdJS #3

merged 6 commits into from
Jun 29, 2023

Conversation

mrtrimble
Copy link
Contributor

@mrtrimble mrtrimble commented Jun 27, 2023 •
edited
Loading

Issue:
#2

Updates:

  • Features:
    • Now using <dialog> which using #top-layer to avoid z-index issues
    • Adds edge detection to reposition dialog if about to overflow on right side
    • Adds resizeObserver to handle resizing browser window
  • Refactor:
    • Updated all dependencies
    • Updated variable namings to be verbose / clearer
    • Cleaned up code to make leaner
  • Updated README.md to be more accurate
  • Created issues based on To Do items

Screenshots:

Screen.Recording.2023-06-29.at.10.23.03.AM.mov

@mrtrimble mrtrimble changed the title [WIP] chore: updates packages, refactors and cleans up code [WIP] Revisiting handholdJS Jun 29, 2023
@mrtrimble mrtrimble changed the title [WIP] Revisiting handholdJS Revisiting handholdJS Jun 29, 2023
@tedk13 tedk13 merged commit 52e05f7 into ritterim:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedk13 tedk13 tedk13 approved these changes

@hougasian hougasian Awaiting requested review from hougasian

@eridolfi12 eridolfi12 Awaiting requested review from eridolfi12

@Azbury Azbury Awaiting requested review from Azbury

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrtrimble @tedk13