Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Replace handling of current scoreDef in Doc" #3522

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Revert "Replace handling of current scoreDef in Doc" #3522

merged 1 commit into from
Sep 28, 2023

Conversation

lpugin
Copy link
Contributor

@lpugin lpugin commented Sep 28, 2023

Reverts #3518

@DavidBauer1984 I am reverting this to narrow down the #3521 issue. Maybe it is unrelated to this PR, which could mean this is a WebAssembly issue.

@lpugin lpugin merged commit 994d1f2 into develop Sep 28, 2023
9 checks passed
@lpugin lpugin deleted the revert-3518-develop-currentScoreDef branch September 28, 2023 19:48
@brdvd
Copy link
Contributor

brdvd commented Sep 28, 2023

OK let me know if I can help somehow or whenever you found any problems with the scoreDef PR.

@brdvd
Copy link
Contributor

brdvd commented Sep 28, 2023

@lpugin I guess I see the problem: the visible scores are not cleaned up during document reset. When doing two successive loads with the toolkit, m_visibleScores still contains scores from the first load. The list is only lazily updated when autogenerating headers and footers, and at this point accesses a destroyed score from the first load.

To fix this, it is probably enough to add m_visibleScores.clear() in Doc::Reset. I can do some more testing and open another PR in the next days.

@lpugin
Copy link
Contributor Author

lpugin commented Sep 28, 2023

Yes, it does look like m_visibleScores is holding invalid data. Since I reverted the PR you can take your time to fix it.

brdvd added a commit to brdvd/verovio that referenced this pull request Oct 5, 2023
@brdvd
Revert "Merge pull request rism-digital#3522 from rism-digital/revert…
baf8d59 
…-3518-develop-currentScoreDef"

This reverts commit 994d1f2, reversing
changes made to ae7c305.
paxbun pushed a commit to clebrain/verovio that referenced this pull request Oct 19, 2023
@lpugin
Increate page width max value to 100000. Fixes rism-digital#3522
3eab703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpugin @brdvd