Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move register layout definitions into wavedrom #414

Open
christian-herber-nxp opened this issue Sep 17, 2024 · 6 comments · May be fixed by #431
Open

Move register layout definitions into wavedrom #414

christian-herber-nxp opened this issue Sep 17, 2024 · 6 comments · May be fixed by #431
Assignees
@wmat @jb-brelot-nxp
Labels
v1.0 resolve for 1.0

Comments

@christian-herber-nxp
Copy link
Collaborator

The privileged spec defines the CSR layouts using wavedrom. The CLIC spec doesn't. This should be aligned.
The layout diagrams do not include descriptions, while the CLIC tables do.

Proposed Resolution:
Move CLIC CSR layouts to wavedrom. Merge the description text with from the layout table with the rest. There might be redundancies, in which the text that doesn't come from the table should take presedence.
@wmat
Copy link
Contributor

wmat commented Sep 23, 2024

Can you point me at a CSR diagram from the Privileged spec that you would expect the CSRs here to look like?

@wmat
Copy link
Contributor

wmat commented Sep 23, 2024

Maybe mnstatus from the rnmi chapter 8.3?

@christian-herber-nxp
Copy link
Collaborator Author

I think we are open to whatever is the preferred presentation by the documentation team. I was looking at the privileged spec itself, i.e. definition of machine mode.

@wmat
Copy link
Contributor

wmat commented Oct 1, 2024

Can you let me know if the content of this diagram is correct? I've left the textual description above the diagram for reference:
Screenshot from 2024-10-01 15-54-46

@christian-herber-nxp
Copy link
Collaborator Author

Can you let me know if the content of this diagram is correct? I've left the textual description above the diagram for reference: Screenshot from 2024-10-01 15-54-46

looks fine

@jb-brelot-nxp
Copy link
Collaborator

looks ok from my side

@jb-brelot-nxp jb-brelot-nxp added the v1.0 resolve for 1.0 label Oct 7, 2024
@jb-brelot-nxp jb-brelot-nxp self-assigned this Oct 7, 2024
wmat added a commit that referenced this issue Nov 11, 2024
@wmat
Add issue #414 to revision history
b14fa3a 
Before issuing PR this adds issue #414 to move register layout definitions to be diagrams.
@wmat wmat linked a pull request Nov 11, 2024 that will close this issue
414 move register layout definitions into wavedrom #431
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmat wmat

@jb-brelot-nxp jb-brelot-nxp

Labels
v1.0 resolve for 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

414 move register layout definitions into wavedrom riscv/riscv-fast-interrupt
3 participants
@wmat @christian-herber-nxp @jb-brelot-nxp