Add unratified Zabha extension #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
reviewed
Nov 1, 2023
riscv/insns/amoadd_b.h
Outdated
| @@ -0,0 +1,3 @@ | |||
| require_extension('A'); | |||
| require_extension(EXT_ZABHA); | |||
| WRITE_RD((sreg_t)(int8_t)(MMU.amo<uint8_t>(RS1, [&](uint8_t lhs) { return lhs + RS2; }))); | |||
There was a problem hiding this comment.
Any reason we can't simplify this to the following:
WRITE_RD(sreg_t(MMU.amo<int8_t>(RS1, [&](int8_t lhs) { return lhs + RS2; })));
If not, let's do the same for everything in Zabha.
There was a problem hiding this comment.
The type cast to int8_t was to do the sign extension and is required. I have updated it to:
WRITE_RD(sreg_t((int8_t)MMU.amo<int8_t>(RS1, [&](int8_t lhs) { return lhs + RS2; })));
There was a problem hiding this comment.
Understood that sign extension is the reason, but you can delete the int8_t cast, because after this change, the function’s return type is already int8_t.
There was a problem hiding this comment.
@aswaterman - I missed that part. I have updated to remove the explicit cast.
aswaterman
reviewed
Nov 1, 2023
aswaterman
reviewed
Nov 1, 2023
aswaterman
reviewed
Nov 1, 2023
ved-rivos
force-pushed
the
zabha
branch
2 times, most recently
from
3cc203a to
d244d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification: https://github.com/riscv/riscv-zabha
Tested with RISC-V arch. tests and checked against sail.