Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vector amo #1481

Merged
merged 4 commits into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions disasm/disasm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1795,41 +1795,6 @@ void disassembler_t::add_instructions(const isa_parser_t* isa)
#undef DISASM_OPIV_S__INSN
#undef DISASM_OPIV_W__INSN
#undef DISASM_VFUNARY0_INSN

// vector amo
std::vector<const arg_t *> v_fmt_amo_wd = {&vd, &v_address, &vs2, &vd, opt, &vm};
std::vector<const arg_t *> v_fmt_amo = {&x0, &v_address, &vs2, &vd, opt, &vm};
for (size_t elt = 0; elt <= 3; ++elt) {
const custom_fmt_t template_insn[] = {
{match_vamoaddei8_v | mask_wd, mask_vamoaddei8_v | mask_wd,
"%sei%d.v", v_fmt_amo_wd},
{match_vamoaddei8_v, mask_vamoaddei8_v | mask_wd,
"%sei%d.v", v_fmt_amo},
};
std::pair<const char*, reg_t> amo_map[] = {
{"vamoswap", 0x01ul << 27},
{"vamoadd", 0x00ul << 27},
{"vamoxor", 0x04ul << 27},
{"vamoand", 0x0cul << 27},
{"vamoor", 0x08ul << 27},
{"vamomin", 0x10ul << 27},
{"vamomax", 0x14ul << 27},
{"vamominu", 0x18ul << 27},
{"vamomaxu", 0x1cul << 27}};
const reg_t elt_map[] = {0x0ul << 12, 0x5ul << 12,
0x6ul <<12, 0x7ul << 12};

for (size_t idx = 0; idx < sizeof(amo_map) / sizeof(amo_map[0]); ++idx) {
for (auto item : template_insn) {
char buf[128];
snprintf(buf, sizeof(buf), item.fmt, amo_map[idx].first, 8 << elt);
add_insn(new disasm_insn_t(buf,
item.match | amo_map[idx].second | elt_map[elt],
item.mask,
item.arg));
}
}
}
}

if (isa->extension_enabled(EXT_ZVFBFMIN)) {
Expand Down
2 changes: 0 additions & 2 deletions riscv/insns/vamoaddei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoaddei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoaddei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoaddei8_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoandei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoandei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoandei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoandei8_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamomaxei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamomaxei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamomaxei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamomaxei8_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamomaxuei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamomaxuei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamomaxuei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamomaxuei8_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamominei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamominei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamominei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamominei8_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamominuei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamominuei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamominuei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamominuei8_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoorei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoorei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoorei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoorei8_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoswapei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoswapei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoswapei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoswapei8_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoxorei16_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoxorei32_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoxorei64_v.h

This file was deleted.

2 changes: 0 additions & 2 deletions riscv/insns/vamoxorei8_v.h

This file was deleted.

39 changes: 0 additions & 39 deletions riscv/riscv.mk.in
Original file line number Diff line number Diff line change
Expand Up @@ -795,44 +795,6 @@ riscv_insn_ext_v_alu_fp = \
vmfne_vf \
vmfne_vv \

riscv_insn_ext_v_amo = \
vamoswapei8_v \
vamoaddei8_v \
vamoandei8_v \
vamomaxei8_v \
vamomaxuei8_v \
vamominei8_v \
vamominuei8_v \
vamoorei8_v \
vamoxorei8_v \
vamoswapei16_v \
vamoaddei16_v \
vamoandei16_v \
vamomaxei16_v \
vamomaxuei16_v \
vamominei16_v \
vamominuei16_v \
vamoorei16_v \
vamoxorei16_v \
vamoswapei32_v \
vamoaddei32_v \
vamoandei32_v \
vamomaxei32_v \
vamomaxuei32_v \
vamominei32_v \
vamominuei32_v \
vamoorei32_v \
vamoxorei32_v \
vamoswapei64_v \
vamoaddei64_v \
vamoandei64_v \
vamomaxei64_v \
vamomaxuei64_v \
vamominei64_v \
vamominuei64_v \
vamoorei64_v \
vamoxorei64_v \

riscv_insn_ext_v_ldst = \
vlm_v \
vle8_v \
Expand Down Expand Up @@ -901,7 +863,6 @@ riscv_insn_ext_v_ctrl = \
riscv_insn_ext_v = \
$(riscv_insn_ext_v_alu_fp) \
$(riscv_insn_ext_v_alu_int) \
$(riscv_insn_ext_v_amo) \
$(riscv_insn_ext_v_ctrl) \
$(riscv_insn_ext_v_ldst) \

Expand Down
54 changes: 0 additions & 54 deletions riscv/v_ext_macros.h
Original file line number Diff line number Diff line change
Expand Up @@ -1399,60 +1399,6 @@ reg_t index[P.VU.vlmax]; \
} \
P.VU.vstart->write(0);

//
// vector: amo
//
#define VI_AMO(op, type, idx_type) \
require_vector(false); \
require_align(insn.rd(), P.VU.vflmul); \
require(P.VU.vsew <= P.get_xlen() && P.VU.vsew >= 32); \
require_align(insn.rd(), P.VU.vflmul); \
float vemul = ((float)idx_type / P.VU.vsew * P.VU.vflmul); \
require(vemul >= 0.125 && vemul <= 8); \
require_align(insn.rs2(), vemul); \
if (insn.v_wd()) { \
require_vm; \
if (idx_type > P.VU.vsew) { \
if (insn.rd() != insn.rs2()) \
require_noover(insn.rd(), P.VU.vflmul, insn.rs2(), vemul); \
} else if (idx_type < P.VU.vsew) { \
if (vemul < 1) { \
require_noover(insn.rd(), P.VU.vflmul, insn.rs2(), vemul); \
} else { \
require_noover_widen(insn.rd(), P.VU.vflmul, insn.rs2(), vemul); \
} \
} \
} \
VI_DUPLICATE_VREG(insn.rs2(), idx_type); \
const reg_t vl = P.VU.vl->read(); \
const reg_t baseAddr = RS1; \
const reg_t vd = insn.rd(); \
for (reg_t i = P.VU.vstart->read(); i < vl; ++i) { \
VI_ELEMENT_SKIP; \
VI_STRIP(i); \
P.VU.vstart->write(i); \
switch (P.VU.vsew) { \
case e32: { \
auto vs3 = P.VU.elt< type ## 32_t>(vd, vreg_inx); \
auto val = MMU.amo<uint32_t>(baseAddr + index[i], [&](type ## 32_t UNUSED lhs) { op }); \
if (insn.v_wd()) \
P.VU.elt< type ## 32_t>(vd, vreg_inx, true) = val; \
} \
break; \
case e64: { \
auto vs3 = P.VU.elt< type ## 64_t>(vd, vreg_inx); \
auto val = MMU.amo<uint64_t>(baseAddr + index[i], [&](type ## 64_t UNUSED lhs) { op }); \
if (insn.v_wd()) \
P.VU.elt< type ## 64_t>(vd, vreg_inx, true) = val; \
} \
break; \
default: \
require(0); \
break; \
} \
} \
P.VU.vstart->write(0);

// vector: sign/unsiged extension
#define VI_VV_EXT(div, type) \
require(insn.rd() != insn.rs2()); \
Expand Down
Loading