Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on version 0.0.2 #162

Closed
ved-rivos opened this issue May 14, 2024 · 5 comments
Closed

Comments on version 0.0.2 #162

ved-rivos opened this issue May 14, 2024 · 5 comments
Assignees
Labels

Comments

@ved-rivos
Copy link
Collaborator

Chapter 5 Some of the requirements are missing the RFC2119 keywords to indicate whether they are mandatory or optional.

ACPI_080 - implies that interrupt controllers may be either PLIC or APLIC. This statement may want to be expanded to include IMSIC and a corresponding RVI ACPI ID provided in section 6.2. In similar vein, section 8.3.6 "the MADT will also contain either PLIC or IMSIC/APLIC structures" would want to be written as "the MADT will also contain either PLIC, APLIC, or IMSIC structures"

@andreiw
Copy link
Collaborator

andreiw commented May 15, 2024

@vlsunil do we need IMSIC in the MADT and (thus) an IMSIC-specific CID for 6.2?

@andreiw
Copy link
Collaborator

andreiw commented May 15, 2024

#163 for Chapter 5 improvements

Will send email to the mailing list to discuss the other points

@andreiw
Copy link
Collaborator

andreiw commented May 16, 2024

#163 is merged.

@andreiw
Copy link
Collaborator

andreiw commented May 20, 2024

Based on #166 and #164, we're good right? @ved-rivos

@ved-rivos
Copy link
Collaborator Author

Thanks! Yes, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants