-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable CI for pull request #77
Conversation
Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace. |
Related to this pr #75 (comment) |
Yeah, I agree. This file was formatted by the suggestion of this issue in official vscode github action extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions. |
FYI, https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml |
If we want to start enforcing a style on these files, then we need to have a CI check to ensure that the file can't be landed in a bad style. |
good idea, using CI lints CI file, haha |
acf4440
to
bd82ed1
Compare
fix tx trie rlp encoding for legacy transactions
@dyxushuai @flaub @intoverflow @Wollac |
Related #75 #76
+r @Wollac