Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable CI for pull request #77

Closed
wants to merge 2 commits into from

Conversation

dyxushuai
Copy link
Contributor

@dyxushuai dyxushuai commented Jan 18, 2024

Related #75 #76
+r @Wollac

@flaub
Copy link
Member

flaub commented Jan 18, 2024

Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

@dyxushuai
Copy link
Contributor Author

Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Related to this pr #75 (comment)

@dyxushuai
Copy link
Contributor Author

dyxushuai commented Jan 18, 2024

I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Yeah, I agree. This file was formatted by the suggestion of this issue in official vscode github action extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions.

@dyxushuai
Copy link
Contributor Author

Yeah, I agree. This file was formatted by the suggestion of this issue in official vscode github action extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions.

FYI, https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml

@flaub
Copy link
Member

flaub commented Jan 18, 2024

If we want to start enforcing a style on these files, then we need to have a CI check to ensure that the file can't be landed in a bad style.

@dyxushuai
Copy link
Contributor Author

good idea, using CI lints CI file, haha

@dyxushuai
Copy link
Contributor Author

good idea, using CI lints CI file, haha

@flaub I added yamllint for CI files and tested it locally. It worked as expected.

johntaiko pushed a commit to johntaiko/zeth that referenced this pull request Apr 10, 2024
fix tx trie rlp encoding for legacy transactions
@hashcashier
Copy link
Contributor

@dyxushuai @flaub @intoverflow @Wollac
Closing this stale PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants