-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error rendering node's pubkey when there's no match on tx #844
Comments
This is because clio nodes don't provide a public key with their clio response. |
@pdp2121 Can you give me the link for the example that you have provided in the image?
Please let me know if this issue is still relevant so I can give it a try. |
You can see it on any invalid transaction hash, e.g. https://livenet.xrpl.org/transactions/E64A81D9FDE13F2FE28A98F337809D894E3279C75ED8E784114C650A04DFC65D
This is definitely an Explorer problem. The |
The code that has the translation is here: https://github.com/ripple/explorer/blob/staging/src/containers/Transactions/index.tsx#L26-L29 The issue stems from One option is scrapping listing the node you are connected to even though this can be helpful information when tracking down why a transaction doesnt exist. Many times it is because a node does not have that ledger. |
|
I would still display it if it exists. |
@mvadari mentioned in a later comment that "nvm, the Clio server_info response doesn't have any pubKey info." I've reached the same conclusion. Upon debugging, I saw that the publicKey is empty. There are these fields in server: "version": "empty",
"uptime": "server's total uptime",
"publicKey": "empty",
"networkId": "current network being used (perhaps the mainnet)",
"uri": "server's webSocket address and port number" I tried changing the line in translations.json and, it worked: "server_ledgers_hint": "This node {{connection.server.uptime}} only contains ledgers {{connection.ledger.validated}}", And it correctly shows the uptime. But the pubKey just won't show up because it is empty. I am genuinely stuck. Is there any solution to this? Or can it not be solved at all? |
I'd personally just leave out the public key part if it doesn't exist, or rewrite the hint to say |
Okay, will do |
The error message on
NoMatch
transactions page should show the node's pubkey, but at the moment it shows a piece of code.The text was updated successfully, but these errors were encountered: