Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: iphone and ipad screen size for android #13

Open
badpenguin opened this issue Feb 25, 2016 · 4 comments
Open

feature request: iphone and ipad screen size for android #13

badpenguin opened this issue Feb 25, 2016 · 4 comments

Comments

@badpenguin
Copy link

Can you please add some android devices with the same screen as the iphone and ipad?
Would be nice to have them for people without IOS for testing the screen size.

Otherwise would be nice to add have the feature to add custom screen size
or that ripple reads a config file.

@badpenguin badpenguin changed the title iphone and ipad for android feature request: iphone and ipad screen size for android Feb 25, 2016
@TimBarham
Copy link
Member

Hey @badpenguin - can't you get the same effect just by adding the ios platform to your Cordova project, then selecting an iPad in Ripple?

@badpenguin
Copy link
Author

@TimBarham nope, it does not works if you're on linux, it only works if you have a mac.
I already did it "in a raw way" by hacking the minified ripple.js in node_modules.

@TimBarham
Copy link
Member

@badpenguin - when you say "does not work", what exactly does happen?

I've tried this on Windows and it works fine there. I'm not aware of any reason it shouldn't work on Linux.

@badpenguin
Copy link
Author

@TimBarham thanks! Maybe something changed in cordova, in the past i was unsable to add the IOS platform to linux, now it works (i just get a warning); then ripple works :)

BTW its still be nice to have the feature to add custom display size when future devices come out (mobile world change each 3 months).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants