Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error is not generated when trying to use UnsafeAccessors in .NET 7 and below. #845

Closed
TimothyMakkison opened this issue Oct 26, 2023 · 2 comments · Fixed by #874
Closed

Error is not generated when trying to use UnsafeAccessors in .NET 7 and below. #845

TimothyMakkison opened this issue Oct 26, 2023 · 2 comments · Fixed by #874

Comments

@TimothyMakkison
Copy link
Collaborator

TimothyMakkison commented Oct 26, 2023 •
edited
Loading

Error UnsafeAccessorNotAvailable is not emitted when trying to use UnsafeAccessors in .NET 7 and below. The code to emit this is dependant on the Roslyn version via a pre-proccessor constant.

Perhaps a more recent Roslyn version pre prccessor constant could be used. Otherwise the diagnostic could be emitted if the UnsafeAccessorAttribute cannot be found. This would have the added benefit of supporting the polyfilled attribute.

See #732
@TimothyMakkison TimothyMakkison mentioned this issue Oct 26, 2023
Closed
@TimothyMakkison TimothyMakkison mentioned this issue Nov 7, 2023
Merged
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.3.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve UnsafeAccessor version check TimothyMakkison/mapperly
1 participant
@TimothyMakkison