Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements system.properties, fixes #456 #457

Merged
merged 1 commit into from
May 20, 2022
Merged

Implements system.properties, fixes #456 #457

merged 1 commit into from
May 20, 2022

Conversation

botic
Copy link
Member

@botic botic commented May 17, 2022

This implements a read-only system.properties export in the system module. The property is unmodifiable to prevent something like this:

// System properties must be strings!
system.properties.foo = {};

@botic botic added this to the 4.0.0 milestone May 17, 2022
@botic botic requested a review from grob May 17, 2022 17:56
@botic
Copy link
Member Author

botic commented May 17, 2022

Btw. working on this uncovered #458

@botic botic mentioned this pull request May 17, 2022
Open
grob
grob approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@grob grob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@botic botic merged commit 15f002d into main May 20, 2022
@botic botic deleted the issues/456-deprecate-env branch May 20, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grob grob grob approved these changes

Assignees
No one assigned
Labels
java javascript
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@botic @grob