Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse models that ingest data from external sources using clickhouse SQL should materialize to true by default #6278

Open
k-anshul opened this issue Dec 13, 2024 · 2 comments
Assignees

Comments

@k-anshul
Copy link
Member

We can only mark models materialized by default for cases when input and output connector are different.
But for clickhouse since we rely on clickhouse connectors to ingest all data it is not possible for us to set that default.
This leads to very hard to know issues where clickhouse keeps pulling data from external source for every query.

The same issue will also be present in duckDB when we move to its internal connectors.

@k-anshul k-anshul self-assigned this Dec 13, 2024
@begelundmuller
Copy link
Contributor

I wonder if there's a way we can analyze a query for external dependencies? For example in DuckDB, maybe creating a temporary view with SET enable_external_access=false?

The same issue will also be present in duckDB when we move to its internal connectors.

For backwards compatibility at least, this can be solved by having type: source emit a model where materialize: true.

@k-anshul
Copy link
Member Author

For example in DuckDB, maybe creating a temporary view with SET enable_external_access=false

Yes this can be evaluated for duckdb. Though enable_external_access once set to false can't be set to true and is a global configuration. We may need to do throw away the write handle once we do this check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants