From 0a81ce9c1e1db2f22cf79ffe2483a8836d03c511 Mon Sep 17 00:00:00 2001
From: Brian Holmes <briangregoryholmes@gmail.com>
Date: Tue, 19 Dec 2023 11:04:23 -0500
Subject: [PATCH] revert if block change

---
 runtime/queries/metricsview.go                |  4 +--
 .../dashboards/filters/Filters.svelte         | 32 +++++++++++++++++++
 2 files changed, 34 insertions(+), 2 deletions(-)

diff --git a/runtime/queries/metricsview.go b/runtime/queries/metricsview.go
index a8ddc324031..eed1960cc3b 100644
--- a/runtime/queries/metricsview.go
+++ b/runtime/queries/metricsview.go
@@ -594,7 +594,7 @@ func convertDimensionFilterToExpression(cond *runtimev1.MetricsViewFilter_Cond,
 		} else {
 			inExpr = expressionpb.In(expressionpb.Identifier(cond.Name), inExprs)
 		}
-	
+	}
 
 	var likeExpr *runtimev1.Expression
 	if len(cond.Like) == 1 {
@@ -631,7 +631,7 @@ func convertDimensionFilterToExpression(cond *runtimev1.MetricsViewFilter_Cond,
 	} else if likeExpr != nil {
 		return likeExpr
 	}
-	}
+	
 
 	return nil
 }
diff --git a/web-common/src/features/dashboards/filters/Filters.svelte b/web-common/src/features/dashboards/filters/Filters.svelte
index 505edb3e07a..fd4c741d459 100644
--- a/web-common/src/features/dashboards/filters/Filters.svelte
+++ b/web-common/src/features/dashboards/filters/Filters.svelte
@@ -1,6 +1,20 @@
 <!-- @component
 The main feature-set component for dashboard filters
  -->
+<script context="module" lang="ts">
+  import { writable } from "svelte/store";
+  import type { Writable } from "svelte/store";
+
+  export const temporaryFilters: Writable<
+    {
+      name: string;
+      label: string;
+      selectedValues: any[];
+      filterType: string;
+    }[]
+  > = writable([]);
+</script>
+
 <script lang="ts">
   import {
     Chip,
@@ -119,14 +133,32 @@ The main feature-set component for dashboard filters
           };
         }) ?? [];
 
+    const currentTemporaryFilters =
+      $temporaryFilters
+        .filter((dimensionValues) => dimensionValues.name !== undefined)
+        .map((dimensionValues) => {
+          const name = dimensionValues.name as string;
+          return {
+            name,
+            label: getDisplayName(
+              dimensionIdMap.get(name) as MetricsViewSpecDimensionV2
+            ),
+            selectedValues: [],
+            filterType: "exclude",
+          };
+        }) ?? [];
+
     currentDimensionFilters = [
       ...currentDimensionIncludeFilters,
       ...currentDimensionExcludeFilters,
+      ...currentTemporaryFilters,
     ];
     // sort based on name to make sure toggling include/exclude is not jarring
     currentDimensionFilters.sort((a, b) => (a.name > b.name ? 1 : -1));
   }
 
+  $: console.log($temporaryFilters);
+
   function setActiveDimension(name, value = "") {
     activeDimensionName = name;
     searchText = value;