Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally provide the backtrace when catching host errors #87

Closed
notmgsk opened this issue Jul 26, 2019 · 2 comments · Fixed by #96
Closed

Optionally provide the backtrace when catching host errors #87

notmgsk opened this issue Jul 26, 2019 · 2 comments · Fixed by #96
Assignees
@appleby

Comments

@notmgsk
Copy link
Contributor

notmgsk commented Jul 26, 2019

server.lisp has a couple error handlers that catch all errors coming out of the host, and those handlers only provide the top-level error. It is helpful during debugging to inspect the backtrace but this is not available currently. One option would be to use handler-bind rather than handler-case (where the stack has already unwound), and provide something like rpcq::*verbose-error* to optionally provide more detailed errors.
@appleby
Copy link
Contributor

appleby commented Jul 26, 2019

I am currently looking into #75 and #61, which touch on related parts of the rcpq server code. If it's not urgent, I could possibly take a look at this as well while I'm mucking around in there.

@notmgsk
Copy link
Contributor Author

notmgsk commented Jul 26, 2019

I am currently looking into #75 and #61, which touch on related parts of the rcpq server code. If it's not urgent, I could possibly take a look at this as well while I'm mucking around in there.

:big-chubby-rubbery-yellow-thumbs-up:

@appleby appleby self-assigned this Jul 26, 2019
appleby added a commit that referenced this issue Nov 8, 2019
@appleby
Add option to log backtraces on handler error
758986c 
Closes #87
appleby added a commit that referenced this issue Nov 8, 2019
@appleby
Add option to log backtraces on handler error
ba2e213 
Closes #87
@appleby appleby mentioned this issue Nov 8, 2019
Closed
appleby added a commit that referenced this issue Nov 8, 2019
@appleby
Add option to log backtraces on handler error
3d8fb79 
Closes #87
@appleby appleby mentioned this issue Nov 8, 2019
Merged
appleby added a commit that referenced this issue Nov 15, 2019
@appleby
Add option to log backtraces on handler error
dbcdd79 
Add a :DEBUG keyword argument to RPCQ:START-SERVER. If non-nil, log a
backtrace when the handler throws an error.

Closes #87
stylewarning pushed a commit that referenced this issue Nov 19, 2019
@appleby @stylewarning
Add option to log backtraces on handler error
f5a7d92 
Add a :DEBUG keyword argument to RPCQ:START-SERVER. If non-nil, log a
backtrace when the handler throws an error.

Closes #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appleby appleby

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@appleby @notmgsk