-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly flakey test #41
Comments
I can reproduce the issue. By keeping a track of the time before we send the event and the Real world example, the time recorded at the beginning of the test is 1656185604104042. Then the event is sent. First found event has 1656185602001000, it is the one from the previous test because the one we just sent is not in the index yet:
Next found event is the expected one, but the time_micros field is 1656185604104000 and appears to be older that the timestamp at the beginning of the test: 1656185604104042
Reverting 5ab5de4 events have "better" resolution:
So the root issue seems to be in the protobuf gem. |
@smortex Happy to have you revert the gem change? Or investigate with them upstream? |
Let's do this for now while we investigate. I am still searching where the magic of setting time_micros happen: can't find it in riemann, nor the protocol buffers gems… The same issue is triggered with the google-protobuf gem (I have some WIP here, but it is only partially functional ATM, I was thinking that using the implementation from google may be a better choice for the long term, also it has less dependencies, is written in C and triggers less errors when running the tests with RSpec 😄). |
https://github.com/riemann/riemann-ruby-client/runs/7054304294?check_suite_focus=true
The text was updated successfully, but these errors were encountered: