(#12) Switch from Beefcake to Protobuf #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance of the Protobuf library is slightly better: comparing the test suite "benchmark" (should query quickly, should be threadsafe) before and after the change, we have the following figures: Queries / second: | Protocol | Before | After | Improvement | |:---------|--------:|-------:|------------:| | TLS | 544.38 | 2957.54| 543% | | TCP | 1076.96 | 3688.43| 342% | | UDP | 1282.52 | 3644.92| 284% | Inserts / second: | Protocol | Before | After | Improvement | |:---------|--------:|--------:|------------:| | TLS | 1452.51 | 5155.62 | 354% | | TCP | 2860.25 | 6709.74 | 234% | | UDP | 4834.24 | 8158.35 | 168% |
|
@aphyr Any thoughts if you have 10 seconds? Just want to make sure nothing weird springs from this? |
|
Heck yeah, perf improvements are always welcome! I've been out of the ruby game for years so I can't speak to library quality, but nothing here seems obviously wrong :-)On Jun 24, 2022 22:33, James Turnbull ***@***.***> wrote:
@aphyr Any thoughts if you have 10 seconds? Just want to make sure nothing weird springs from this?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Then I think this is an excellent update @smortex +1 from me too. |
|
For the record, this was reverted in #42 because it cause some CI regression because of time resolution. The initial issue is open again so that we can still have this in mind. I'll mark both PR as skip-changelog because this code was never released. |
smortex
added
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance of the Protobuf library is slightly better: comparing the
test suite "benchmark" (should query quickly, should be threadsafe)
before and after the change, we have the following figures:
Queries / second:
Inserts / second:
Fixes #12