Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TL discriminator for skill defaults #813

Open
rinickolous opened this issue Feb 16, 2024 · 1 comment
Open

Add TL discriminator for skill defaults #813

rinickolous opened this issue Feb 16, 2024 · 1 comment

Comments

@rinickolous
Copy link

Some skills have different defaults depending on TL. An example of this is the Armoury skill in Basic Set, which has different defaults based on its TL.

I propose adding a NumericCriteria to the SkillDefaults object, omitted from the data if set to "any", which causes the skill default to apply only if the criteria is met.

An alternative to this would be making duplicate listings in the various libraries for skills to which this applies. However, this seems more elegant and should be simple to implement.

@smithkm
Copy link
Contributor

smithkm commented Jul 27, 2024

There are other conditional defaults like certain techniques that have a different default depending on whether the character has an appropriate cinematic combat trait TBaM/WM/Heroic Archer/Gunslinger. It would be good to handle this in a general way that accommodates both, or makes other conditional defaults easier to build in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants