Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize results parsing to deal with other field-aligned codes #79

Open
wtbarnes opened this issue Jan 30, 2020 · 0 comments
Open

Generalize results parsing to deal with other field-aligned codes #79

wtbarnes opened this issue Jan 30, 2020 · 0 comments
Labels

Comments

@wtbarnes
Copy link
Member

Following discussion at the field-aligned modeling ISSI meeting, there's a consensus that having a single package to read output from multiple models and expose them via a single API would be very useful.

Currently, the Strand object is tied fairly closely to the reading of HYDRAD results. A reasonable plan might be to pull out the non-HYDRAD specific bits, create a BaseStrand object and then let HYDRADStrand, RADYNStrand, etc. inherit from this. We could then use a factory pattern such that users instantiate a Strand and the particular subclass is created based on the input file type. This is similar to how the Map object works in SunPy.

@Goobley has already developed radynpy so we should be able to benefit from the readers already implemented there. These could be pulled into this package or radynpy could just be an optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant